From mboxrd@z Thu Jan 1 00:00:00 1970 From: Antonino Daplas Subject: Re: Much better framebuffer fixes. Date: 28 Mar 2003 03:15:23 +0800 Sender: linux-fbdev-devel-admin@lists.sourceforge.net Message-ID: <1048792147.1086.28.camel@localhost.localdomain> References: Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: Received: from pine.compass.com.ph ([202.70.96.37]) by sc8-sf-list1.sourceforge.net with smtp (Exim 3.31-VA-mm2 #1 (Debian)) id 18yd8a-0007hB-00 for ; Thu, 27 Mar 2003 11:34:09 -0800 In-Reply-To: Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Id: List-Unsubscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: Geert Uytterhoeven Cc: James Simmons , Linux Kernel Mailing List , Linux Fbdev development list On Thu, 2003-03-27 at 17:18, Geert Uytterhoeven wrote: > On Thu, 27 Mar 2003, James Simmons wrote: > > drivers/video/logo/logo.c | 69 +++++------ > > Are you sure the change from logo type to logo depth in (fb_)find_logo() won't > have any side effects? After this change, you may receive a different type of > logo than you requested. > I agree. Take the case of Directcolor. At 16-bpp, it needs linux_logo_vga16, not linux_logo_clut224. Also, monochrome at 8bpp needs linux_logo_mono, certainly not linux_logo_clut224. There are obviously other similar cases. I think the original logo code in both logo.c and fbmem.c, though a bit more confusing, provides better ways of choosing the correct logo. Tony ------------------------------------------------------- This SF.net email is sponsored by: The Definitive IT and Networking Event. Be There! NetWorld+Interop Las Vegas 2003 -- Register today! http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en