From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Paul Mackerras <paulus@samba.org>
Cc: James Simmons <jsimmons@infradead.org>,
linux-kernel mailing list <linux-kernel@vger.kernel.org>,
Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: [PATCH] fix controlfb and platinumfb drivers
Date: 28 May 2003 14:36:16 +0200 [thread overview]
Message-ID: <1054125376.538.1.camel@gaston> (raw)
In-Reply-To: <16083.61404.354044.232004@nanango.paulus.ozlabs.org>
On Wed, 2003-05-28 at 01:08, Paul Mackerras wrote:
> James Simmons writes:
>
> > Applied. Tho it is strnage. You shouldn't need to call fb_set_var from the
> > driver.
>
> It's just convenient to use fb_set_var to get the hardware set to the
> initial mode. Would it be better to call controlfb_check_var,
> controlfb_set_par, etc., directly?
I think we are supposed to rely on the console subsytem opening us thus
doing a set_par() with the initial var rather than doing set_var ourselves,
but I'm not too sure, I added those set_var at a time where I had incorrect
results without, we may be able to remove them by now...
Ben.
-------------------------------------------------------
This SF.net email is sponsored by: ObjectStore.
If flattening out C++ or Java code to make your application fit in a
relational database is painful, don't do it! Check out ObjectStore.
Now part of Progress Software. http://www.objectstore.net/sourceforge
prev parent reply other threads:[~2003-05-28 12:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-24 11:40 [PATCH] fix controlfb and platinumfb drivers Paul Mackerras
2003-05-27 22:29 ` James Simmons
2003-05-27 23:08 ` [Linux-fbdev-devel] " Paul Mackerras
2003-05-28 12:36 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1054125376.538.1.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=jsimmons@infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).