[PATCH] fix controlfb and platinumfb drivers

[PATCH] fix controlfb and platinumfb drivers

[Paul Mackerras]

James,

This patch fixes the controlfb and platinumfb drivers so that the
arguments to fb_set_var are in the correct order.  Please apply.

Thanks,
Paul.

diff -urN linux-2.5/drivers/video/controlfb.c pmac-2.5/drivers/video/controlfb.c
--- linux-2.5/drivers/video/controlfb.c	2003-04-25 22:19:46.000000000 +1000
+++ pmac-2.5/drivers/video/controlfb.c	2003-05-21 13:32:42.000000000 +1000
@@ -475,7 +475,7 @@
 
 	/* Apply default var */
 	var.activate = FB_ACTIVATE_NOW;
-	rc = fb_set_var(&var, &p->info);
+	rc = fb_set_var(&p->info, &var);
 	if (rc && (vmode != VMODE_640_480_60 || cmode != CMODE_8))
 		goto try_again;
 
diff -urN linux-2.5/drivers/video/platinumfb.c pmac-2.5/drivers/video/platinumfb.c
--- linux-2.5/drivers/video/platinumfb.c	2003-04-25 22:19:46.000000000 +1000
+++ pmac-2.5/drivers/video/platinumfb.c	2003-05-21 13:33:01.000000000 +1000
@@ -399,7 +399,7 @@
 	/* Apply default var */
 	p->info.var = var;
 	var.activate = FB_ACTIVATE_NOW;
-	rc = fb_set_var(&var, &p->info);
+	rc = fb_set_var(&p->info, &var);
 	if (rc && (default_vmode != VMODE_640_480_60 || default_cmode != CMODE_8))
 		goto try_again;
 

Re: [PATCH] fix controlfb and platinumfb drivers

[James Simmons]

> This patch fixes the controlfb and platinumfb drivers so that the
> arguments to fb_set_var are in the correct order.  Please apply.

Applied. Tho it is strnage. You shouldn't need to call fb_set_var from the 
driver. 



-------------------------------------------------------
This SF.net email is sponsored by: ObjectStore.
If flattening out C++ or Java code to make your application fit in a
relational database is painful, don't do it! Check out ObjectStore.
Now part of Progress Software. http://www.objectstore.net/sourceforge

Re: [Linux-fbdev-devel] [PATCH] fix controlfb and platinumfb drivers

[Paul Mackerras]

James Simmons writes:

> Applied. Tho it is strnage. You shouldn't need to call fb_set_var from the 
> driver. 

It's just convenient to use fb_set_var to get the hardware set to the
initial mode.  Would it be better to call controlfb_check_var,
controlfb_set_par, etc., directly?

Paul.

Re: [PATCH] fix controlfb and platinumfb drivers

[Benjamin Herrenschmidt]

On Wed, 2003-05-28 at 01:08, Paul Mackerras wrote:
> James Simmons writes:
> 
> > Applied. Tho it is strnage. You shouldn't need to call fb_set_var from the 
> > driver. 
> 
> It's just convenient to use fb_set_var to get the hardware set to the
> initial mode.  Would it be better to call controlfb_check_var,
> controlfb_set_par, etc., directly?

I think we are supposed to rely on the console subsytem opening us thus
doing a set_par() with the initial var rather than doing set_var ourselves,
but I'm not too sure, I added those set_var at a time where I had incorrect
results without, we may be able to remove them by now...

Ben.



-------------------------------------------------------
This SF.net email is sponsored by: ObjectStore.
If flattening out C++ or Java code to make your application fit in a
relational database is painful, don't do it! Check out ObjectStore.
Now part of Progress Software. http://www.objectstore.net/sourceforge