From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH] fix controlfb and platinumfb drivers Date: 28 May 2003 14:36:16 +0200 Sender: linux-fbdev-devel-admin@lists.sourceforge.net Message-ID: <1054125376.538.1.camel@gaston> References: <16079.23061.979768.135318@argo.ozlabs.ibm.com> <16083.61404.354044.232004@nanango.paulus.ozlabs.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: Received: from griffon.mipsys.com ([217.167.51.129] helo=gaston) by sc8-sf-list1.sourceforge.net with esmtp (Exim 3.31-VA-mm2 #1 (Debian)) id 19L0Aq-0004Hb-00 for ; Wed, 28 May 2003 05:36:56 -0700 In-Reply-To: <16083.61404.354044.232004@nanango.paulus.ozlabs.org> Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Id: List-Unsubscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: Paul Mackerras Cc: James Simmons , linux-kernel mailing list , Linux Fbdev development list On Wed, 2003-05-28 at 01:08, Paul Mackerras wrote: > James Simmons writes: > > > Applied. Tho it is strnage. You shouldn't need to call fb_set_var from the > > driver. > > It's just convenient to use fb_set_var to get the hardware set to the > initial mode. Would it be better to call controlfb_check_var, > controlfb_set_par, etc., directly? I think we are supposed to rely on the console subsytem opening us thus doing a set_par() with the initial var rather than doing set_var ourselves, but I'm not too sure, I added those set_var at a time where I had incorrect results without, we may be able to remove them by now... Ben. ------------------------------------------------------- This SF.net email is sponsored by: ObjectStore. If flattening out C++ or Java code to make your application fit in a relational database is painful, don't do it! Check out ObjectStore. Now part of Progress Software. http://www.objectstore.net/sourceforge