Unifying radeon.h constant files

Unifying radeon.h constant files

[Jon Smirl]

What do you think about getting rid of include/video/radeon.h and replacing it
with the much more comprehensive one from XFree86? It would make life easier if
constants had the same names in the kernel and XFree86 code. radeonfb would
need to be touched up for about 100 name changes. 

char/drm/radeon_drv.h has a third set of names but that is up to the DRI people
to fix. If we can get radeonfb and 2D XFree on the same set of names I'll see
if I can get the 3D people to go along.

If this works for Radeon we should do it for Rage128 too.

=====
Jon Smirl
jonsmirl@yahoo.com

__________________________________
Do you Yahoo!?
Yahoo! SiteBuilder - Free, easy-to-use web site design software
http://sitebuilder.yahoo.com


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: Unifying radeon.h constant files

[Benjamin Herrenschmidt]

On Mon, 2003-09-01 at 07:25, Jon Smirl wrote:
> What do you think about getting rid of include/video/radeon.h and replacing it
> with the much more comprehensive one from XFree86? It would make life easier if
> constants had the same names in the kernel and XFree86 code. radeonfb would
> need to be touched up for about 100 name changes. 
> 
> char/drm/radeon_drv.h has a third set of names but that is up to the DRI people
> to fix. If we can get radeonfb and 2D XFree on the same set of names I'll see
> if I can get the 3D people to go along.
> 
> If this works for Radeon we should do it for Rage128 too.

I'm all for doing that, but not until I've finished the new version of
the driver ;) Also, I have a bunch of additional constants used by the
Power Management code that don't have the RADEON_ prefix neither and are
not in XFree, we would have to fixup that too. 

Ben.



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: Re: Unifying radeon.h constant files

[Jon Smirl]

--- Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> I'm all for doing that, but not until I've finished the new version of
> the driver ;) Also, I have a bunch of additional constants used by the
> Power Management code that don't have the RADEON_ prefix neither and are
> not in XFree, we would have to fixup that too. 
> 
Do you want to try doing the fixups for XFree H file then? 

Have you merged with Luca and me from mesa3d.bkbit.net/linux-2.5 yet? There
will probably be conflicts where I rewrote the error handling in the
intialization code. The old code made mistakes freeing resource when errors
ocurred.

Send me an rsa1 key and I can add you as a writer.

=====
Jon Smirl
jonsmirl@yahoo.com

__________________________________
Do you Yahoo!?
Yahoo! SiteBuilder - Free, easy-to-use web site design software
http://sitebuilder.yahoo.com


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: Re: Unifying radeon.h constant files

[Benjamin Herrenschmidt]

On Mon, 2003-09-01 at 17:56, Jon Smirl wrote:
> --- Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> > I'm all for doing that, but not until I've finished the new version of
> > the driver ;) Also, I have a bunch of additional constants used by the
> > Power Management code that don't have the RADEON_ prefix neither and are
> > not in XFree, we would have to fixup that too. 
> > 
> Do you want to try doing the fixups for XFree H file then? 

> Have you merged with Luca and me from mesa3d.bkbit.net/linux-2.5 yet? There
> will probably be conflicts where I rewrote the error handling in the
> intialization code. The old code made mistakes freeing resource when errors
> ocurred.

I've done the merge in my WIP tree where i'm working on a split version
of the driver, I did some other changes to the EDID stuff (probing all
ports and using a slightly different logic to pick the main one, also
I'm trying to pave the way to full multihead).

It's not ready yet, hopefully I'll have that up before next week.

> Send me an rsa1 key and I can add you as a writer.

Talk to you about this later.

Ben.




-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf