Re: Re: New radeonfb, mostly untested

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Tue, 2003-09-09 at 21:24, Kronos wrote:

> Most of work consists in changing "." into "->" ;)
> Changes to fbmem.c are very similar to Greg KH's patch:

You probably want to fix more drivers , that would help getting
it merged. I will take care of all the pmac ones (controlfb,
platinumfb, valkyriefb) and I can take care of aty128fb,
chipsfb and radeonfb too if necessary.

Some comments though:

>+static void release_fb_info(struct class_device *class_dev) {
>+       struct fb_info *info = to_fb_info(class_dev);
>+
>+       if (info->release)
>+               info->release(info);
>+       
>+       kfree(info);
>+}

Since you provide the implicit kfree(), you should also provide an
framebuffer_alloc() some for consistency imho. That would take the
size of the private structure like for netdevs and allocate both.

> +static struct class fb_class = {
> +	.name		= "video",

I'd rather use "display" here. "video" is too broad and will cause
confusion with multimedia stuff.

Ben.




-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf