From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: Re: New radeonfb, mostly untested Date: Tue, 09 Sep 2003 23:07:31 +0200 Sender: linux-fbdev-devel-admin@lists.sourceforge.net Message-ID: <1063141651.20501.50.camel@gaston> References: <1062960554.647.34.camel@gaston> <20030909175404.GA8039@dreamland.darkstar.lan> <1063131198.642.5.camel@gaston> <20030909192430.GA10981@dreamland.darkstar.lan> <1063136237.639.42.camel@gaston> <20030909204544.GA16724@dreamland.darkstar.lan> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.11] helo=sc8-sf-mx1.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Cipher TLSv1:DES-CBC3-SHA:168) (Exim 3.31-VA-mm2 #1 (Debian)) id 19wpif-0001TP-00 for ; Tue, 09 Sep 2003 14:08:13 -0700 Received: from pentafluge.infradead.org ([213.86.99.235]) by sc8-sf-mx1.sourceforge.net with esmtp (TLSv1:AES256-SHA:256) (Exim 4.22) id 19wpie-0006EZ-Nn for linux-fbdev-devel@lists.sourceforge.net; Tue, 09 Sep 2003 14:08:13 -0700 In-Reply-To: <20030909204544.GA16724@dreamland.darkstar.lan> Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Id: List-Unsubscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: Kronos Cc: James Simmons , Jon Smirl , Linux Fbdev development list > > struct fb_info *framebuffer_alloc(size_t size, struct device *dev) { > struct fb_info *ret; > > ret = kmalloc(sizeof(struct fb_info) + size, GFP_KERNEL); > if (!ret) > return NULL; > memset(ret, 0, sizeof(struct fb_info) + size); Except I would also make sure that there is some alignement of the private part, if possible on L1 cache line size Ben. ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf