Re: Re: New radeonfb, mostly untested

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Thu, 2003-09-11 at 08:03, Geert Uytterhoeven wrote:
> On Wed, 10 Sep 2003, Benjamin Herrenschmidt wrote:
> > > It  fails only  if  compiled  as module. I  see  that fb_find_mode  (and
> > > my_atoi) are marked  as __init. Maybe they get discarded  after boot and
> > > when  radeonfb module  tries  to call  them it  ends  up in  deallocated
> > > memory...
> > 
> > Exactly, they should definitely not be marked __init
> 
> That doesn't harm. If MODULE is defined, fb_find_mode() is an inline function
> that knows about 640x400@70 only, cfr. <linux/fb.h>.

But that's wrong ! Why would you want to prevent a modular driver to
use fb_find_mode ? Especially in that case where I'm looking for a mode
in the modedb built from EDID list...

On the other hand, if I add the flags for "detailed timings" vs "calculated"
in the modedb list obtained from EDID, I will have to parse the list
manually or change fb_find_mode prototype, to get to the detailed timing...
Another possibility is to change my algorithm to first use the mode returned
by parse_edid (which is from the detailed timings), then only fallback to
fb_find_mode

Ben.



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf