From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Michel Dänzer" <michel@daenzer.net>
Cc: Jon Smirl <jonsmirl@yahoo.com>,
Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: Problem with radeon new ROM probe code
Date: Wed, 24 Sep 2003 19:44:10 +0200 [thread overview]
Message-ID: <1064425449.15996.58.camel@gaston> (raw)
In-Reply-To: <1064416682.10673.52.camel@thor.holligenstrasse29.lan>
On Wed, 2003-09-24 at 17:18, Michel Dänzer wrote:
> On Wed, 2003-09-24 at 14:06, Benjamin Herrenschmidt wrote:
> >
> > Your new code for looking at the card's ROM is causing a problem for
> > me. On some cards, typically the "Mac" cards, the ROM doesn't contain
> > an x86 BIOS, but rather an OF driver. The current code will blindly
> > tap that, though it contains none of the expected tables, and will
> > use completely wrong values.
> >
> > Do you have ideas how to make some sanity checking on the ROM content ?
>
> The X radeon driver has this in RADEONGetBIOSParameters():
>
> if (info->VBIOS[0] != 0x55 || info->VBIOS[1] != 0xaa) {
We check that, but that isn't enough, an OF ROM will trigger that
as well
Ben.
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
next prev parent reply other threads:[~2003-09-24 17:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-24 12:06 Problem with radeon new ROM probe code Benjamin Herrenschmidt
2003-09-24 15:18 ` Michel Dänzer
2003-09-24 17:44 ` Benjamin Herrenschmidt [this message]
[not found] ` <20030924181257.78090.qmail@web14914.mail.yahoo.com>
2003-09-25 5:39 ` Sven Luther
2003-09-25 12:10 ` Stefan Reinauer
2003-09-25 13:41 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1064425449.15996.58.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=jonsmirl@yahoo.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=michel@daenzer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).