From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michel =?ISO-8859-1?Q?D=E4nzer?= Subject: Re: Re: [PATCH] Radeon 2D Acceleration for 2.6 Date: Fri, 23 Jan 2004 02:22:56 +0100 Sender: linux-fbdev-devel-admin@lists.sourceforge.net Message-ID: <1074820975.367.179.camel@thor.asgaard.local> References: <1074638876.793.47.camel@gaston> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.11] helo=sc8-sf-mx1.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1Ajq2H-0004Xg-HI for linux-fbdev-devel@lists.sourceforge.net; Thu, 22 Jan 2004 17:23:01 -0800 Received: from netline-mail1.netline.ch ([195.141.226.27]) by sc8-sf-mx1.sourceforge.net with esmtp (Exim 4.30) id 1Ajq2G-0006mi-Sb for linux-fbdev-devel@lists.sourceforge.net; Thu, 22 Jan 2004 17:23:01 -0800 In-Reply-To: Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: List-Post: List-Help: List-Subscribe: , List-Archive: Content-Type: text/plain; charset="iso-8859-1" To: random Cc: Benjamin Herrenschmidt , Linux Fbdev development list On Wed, 2004-01-21 at 00:09, random wrote:=20 >=20 > +void radeonfb_prim_fillrect(struct radeonfb_info *rinfo,=20 > + const struct fb_fillrect *region) > +{ > + radeon_fifo_wait(4); =20 > + =20 > + OUTREG(DP_GUI_MASTER_CNTL, =20 > + rinfo->dp_gui_master_cntl /* contains, like GMC_DST_32BPP */ > + | GMC_BRUSH_SOLID_COLOR > + | ROP3_P); > + OUTREG(DP_BRUSH_FRGD_CLR, region->color); > + OUTREG(DP_WRITE_MSK, 0xffffffff); You could probably take this out of the acceleration functions, you don't seem to need a different write mask? > + OUTREG(DP_CNTL, (DST_X_LEFT_TO_RIGHT | DST_Y_TOP_TO_BOTTOM)); > + > + radeon_fifo_wait(2); =20 > + OUTREG(DST_Y_X, (region->dy << 16) | region->dx); > + OUTREG(DST_WIDTH_HEIGHT, (region->width << 16) | region->height); > + radeon_engine_idle (); Why idle the engine in every acceleration function? Doesn't the API provide a way to only do it when necessary? PS: You lost my last reply to your private mails to your temporary address scheme. --=20 Earthling Michel D=C3=A4nzer | Debian (powerpc), X and DRI develop= er Libre software enthusiast | http://svcs.affero.net/rm.php?r=3Ddaenzer ------------------------------------------------------- The SF.Net email is sponsored by EclipseCon 2004 Premiere Conference on Open Tools Development and Integration See the breadth of Eclipse activity. February 3-5 in Anaheim, CA. http://www.eclipsecon.org/osdn