linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexander Kern <alex.kern@gmx.de>
Cc: Linux Fbdev development list <linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: atyfb expert needed
Date: Tue, 17 Feb 2004 17:00:10 +1100	[thread overview]
Message-ID: <1076997609.1046.168.camel@gaston> (raw)
In-Reply-To: <200402141626.39311.alex.kern@gmx.de>

On Sun, 2004-02-15 at 02:26, Alexander Kern wrote:
> Am Samstag, 14. Februar 2004 00:20 schrieb Benjamin Herrenschmidt:
> > > Hi,
> > > mach64_ct.c(where aty_dsp_gt is) from James tree should be identical with
> > > Daniel'S 2.4 tree. If not, please send me the diff.
> >
> > Is Daniel's latest version in current 2.4 or is there another source
> > for his patches ?

Ok. Comparing 2.4.24 & 2.6.3/fbdev to XFree driver, it seems that
2.6.3/fbdev matches XFree more closely.... Except that we are missing
the FIFO_24 attribute for the LT-G chip.

Fixing that leads to slightly less crapy display, but still unreadable... until
I figured out that acceleration (imageblit more precisely) has broken endianness...

This kludge fixes it for me (maybe incorrect, just a quick fix) :

@@ -419,9 +425,9 @@
                }
        } else {
                u32 *pbitmap;
-               for(pbitmap = (u32*)(image->data); dwords; dwords--, pbitmap++) {
-                       wait_for_fifo(1, par);
-                       aty_st_le32(HOST_DATA0, *pbitmap, par);
+               for (pbitmap = (u32*)(image->data); dwords; dwords--, pbitmap++) {
+                       wait_for_fifo(2, par);
+                       aty_st_le32(HOST_DATA0, le32_to_cpup(pbitmap), par);
                }
 
_BUT_ then, I get a lockup when reaching the end of the screen... Apparently,
it locks up when drawin the last line, not sure if it did a scroll yet or not.
I'm playing with the accel fifo a bit, but that's definitely a regression.

Ben.






-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click

  reply	other threads:[~2004-02-17  6:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-11 22:10 atyfb expert needed Benjamin Herrenschmidt
2004-02-11 22:29 ` James Simmons
2004-02-12  9:29 ` Geert Uytterhoeven
2004-02-12  9:45   ` Daniël Mantione
2004-02-12  9:55     ` Geert Uytterhoeven
2004-02-13 15:41   ` Alexander Kern
2004-02-13 23:20     ` Benjamin Herrenschmidt
2004-02-14 15:26       ` Alexander Kern
2004-02-17  6:00         ` Benjamin Herrenschmidt [this message]
2004-02-17  6:41           ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1076997609.1046.168.camel@gaston \
    --to=benh@kernel.crashing.org \
    --cc=alex.kern@gmx.de \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).