Re: scrollmode, accel_flags, fbcon.c ...

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Fri, 2004-03-26 at 11:14, David Eger wrote:
> are scrollmode or accel_flags meaningful to anyone here?
> 
> Paging through fbcon.c, I've realized why the radeonfb driver is still 
> slow -- the accelerated functions are never being called!  
> 
> Hardwiring scrollmode to __SCROLL_YMOVE in updatescrollmode() makes my 
> console go a lot faster :)

Heh, good catch ;)

> So within fbcon.c why is there a "scrollmode" variable which can be set
> to:  __SCROLL_YWRAP, __SCROLL_YPAN, __SCROLL_YREDRAW, or __SCROLL_YMOVE?

Never been too sure about those. James ?

> Also accel_flags actually useful to anyone?  I see in the fb code some
> half-hearted attempts to test for FB_ACCELF_TEXT, but it's not clear at
> all to me where these accel flags are supposed to be set... are they even
> relevant with the new accel interface?  It seems all this is properly
> replaced by filling in the fbops to either the driver's custom fillrect()
> or cfb_fillrect(), no?

I think they are irrelevant, I removed most of the stuff using that
in radeonfb, it would not work properly. I'm not sure what to do with
the scrollmode though. I'll have to experiment.

Ben.



-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click