linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Eger <eger-dated-1081179398.a664d4@theboonies.us>
Cc: Linux Fbdev development list
	<linux-fbdev-devel@lists.sourceforge.net>,
	James Simmons <jsimmons@infradead.org>
Subject: Re: [PATCH] radeonfb: copyarea() "memmove()" problem
Date: Wed, 31 Mar 2004 09:00:10 +1000	[thread overview]
Message-ID: <1080687610.1213.50.camel@gaston> (raw)
In-Reply-To: <Pine.LNX.4.58.0403291709020.2356@rosencrantz.theboonies.us>

On Tue, 2004-03-30 at 01:13, David Eger wrote:
> Now that my local kernel actually calls copyarea(), I see that my code was
> buggy... That is, the hardware needs to be told which way to do its memory
> copies if areas overlap.  Think of memmove() versus memcpy().  
> Attached is the fix.
> 
> Unfortunately, I think the fbcon layer is also buggy... 
> (try opening a file with vim, and typing "5ddP"  the copyarea()'s that 
> get sent to the fb driver seem totally bogus...)

Excellent. James, any clue about the copyarea issue ?

Ben.




-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click

  parent reply	other threads:[~2004-03-30 23:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-29 15:13 [PATCH] radeonfb: copyarea() "memmove()" problem David Eger
2004-03-29 15:49 ` Geert Uytterhoeven
2004-03-30 23:00 ` Benjamin Herrenschmidt [this message]
2004-04-02 23:49   ` James Simmons
2004-04-11 19:06     ` David Eger
2004-04-14 18:08       ` James Simmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1080687610.1213.50.camel@gaston \
    --to=benh@kernel.crashing.org \
    --cc=eger-dated-1081179398.a664d4@theboonies.us \
    --cc=jsimmons@infradead.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).