From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Eger <eger-dated-1082943669.d79d33@theboonies.us>,
James Simmons <jsimmons@infradead.org>
Cc: Linux Frame Buffer Device Development
<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: [PATCH] radeonfb(): memmove() fix -- this one works ;-)
Date: Mon, 19 Apr 2004 11:52:57 +1000 [thread overview]
Message-ID: <1082339577.15101.4.camel@gaston> (raw)
In-Reply-To: <Pine.LNX.4.58.0404190339060.2288@rosencrantz.theboonies.us>
,On Mon, 2004-04-19 at 11:46, David Eger wrote:
> Dear Ben,
>
> Please apply this patch to the radeonfb driver (I think of you as the
> maintainer for this driver) and then forward to James and Linus :-)
>
> This fixes the same problem as mentioned before -- overlapping
> regions sent to copyarea() get fux0r3d. This patch corrects my earlier
> braindamage of setting up w, h, dx, etc. and then forgetting to use them
> later on. Ah, having two versions of the same code (userspace and kernel
> space) -- little details like that just float past the eye... no problem
> with fbcon at all, as i previously speculated. apologies to james.
BTW, James, did we decide what is the best way to set fbcon accel
mode ? For drivers with copyarea accelerated, we want YMOVE. I'd like
a patch to send Linus/Andrew asap along with some pending radeonfb
fixes for that.
Ben.
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
next prev parent reply other threads:[~2004-04-19 1:58 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-19 1:46 [PATCH] radeonfb(): memmove() fix -- this one works ;-) David Eger
2004-04-19 1:50 ` Benjamin Herrenschmidt
2004-04-19 1:52 ` Benjamin Herrenschmidt [this message]
2004-04-20 22:52 ` James Simmons
2004-04-21 0:30 ` Benjamin Herrenschmidt
2004-04-21 18:03 ` James Simmons
2004-04-21 23:08 ` Benjamin Herrenschmidt
[not found] ` <12573.10.250.10.1.1082504618.squirrel@sq01.pol.net>
2004-04-21 0:30 ` Benjamin Herrenschmidt
2004-04-21 8:28 ` Geert Uytterhoeven
2004-04-21 10:36 ` Benjamin Herrenschmidt
2004-04-21 10:50 ` Geert Uytterhoeven
2004-04-21 18:13 ` James Simmons
2004-04-21 19:35 ` Antonino A. Daplas
2004-04-22 8:22 ` Geert Uytterhoeven
2004-04-27 0:19 ` James Simmons
2004-04-27 0:22 ` Benjamin Herrenschmidt
2004-04-27 8:51 ` Geert Uytterhoeven
2004-04-27 9:43 ` David Eger
2004-04-27 9:57 ` Geert Uytterhoeven
2004-04-27 10:09 ` Benjamin Herrenschmidt
2004-04-27 11:19 ` Geert Uytterhoeven
2004-04-27 22:41 ` John Zielinski
2004-04-27 10:10 ` Benjamin Herrenschmidt
2004-04-27 11:21 ` Geert Uytterhoeven
2004-04-27 20:28 ` James Simmons
2004-04-27 20:27 ` James Simmons
2004-04-27 22:28 ` John Zielinski
2004-04-27 22:33 ` James Simmons
2004-04-27 22:59 ` John Zielinski
2004-04-27 23:14 ` Benjamin Herrenschmidt
2004-04-27 23:24 ` James Simmons
2004-04-27 23:28 ` Benjamin Herrenschmidt
2004-04-27 23:57 ` James Simmons
2004-04-28 0:12 ` Benjamin Herrenschmidt
2004-04-28 1:12 ` John Zielinski
2004-04-28 1:50 ` Benjamin Herrenschmidt
2004-04-28 16:51 ` James Simmons
2004-04-28 0:18 ` John Zielinski
2004-04-27 23:02 ` Benjamin Herrenschmidt
2004-04-27 23:18 ` James Simmons
2004-04-27 23:25 ` Benjamin Herrenschmidt
2004-04-27 23:51 ` James Simmons
2004-04-27 23:53 ` Benjamin Herrenschmidt
2004-04-28 8:41 ` Geert Uytterhoeven
2004-04-28 10:00 ` Benjamin Herrenschmidt
2004-04-28 16:48 ` James Simmons
2004-04-28 23:31 ` Benjamin Herrenschmidt
2004-04-29 0:02 ` James Simmons
2004-04-29 0:50 ` Benjamin Herrenschmidt
2004-04-29 18:01 ` James Simmons
2004-04-29 18:11 ` Otto Solares
[not found] ` <20040429194813.GA8799@dreamland.darkstar.lan>
2004-04-29 20:13 ` Otto Solares
2004-04-30 16:03 ` James Simmons
2004-04-29 21:58 ` Benjamin Herrenschmidt
2004-04-30 16:05 ` James Simmons
2004-04-30 23:57 ` Benjamin Herrenschmidt
2004-04-28 16:29 ` James Simmons
2004-04-28 17:56 ` Geert Uytterhoeven
2004-04-28 19:05 ` James Simmons
2004-04-28 23:00 ` John Zielinski
2004-04-28 23:29 ` Benjamin Herrenschmidt
2004-04-29 0:26 ` James Simmons
2004-04-29 0:38 ` Otto Solares
2004-04-29 8:28 ` [PATCH] radeonfb(): memmove() fix -- this one works ; -) Geert Uytterhoeven
2004-04-28 1:00 ` [PATCH] radeonfb(): memmove() fix -- this one works ;-) John Zielinski
2004-04-28 16:38 ` James Simmons
2004-04-28 22:11 ` John Zielinski
2004-04-28 4:43 ` Alex Stewart
2004-04-28 17:54 ` James Simmons
2004-04-28 21:51 ` Alex Stewart
2004-04-28 21:52 ` James Simmons
2004-04-28 23:35 ` Alex Stewart
2004-04-27 23:54 ` John Zielinski
2004-04-28 0:47 ` Antonino A. Daplas
2004-04-28 8:35 ` [PATCH] radeonfb(): memmove() fix -- this one works ; -) Geert Uytterhoeven
2004-04-28 17:14 ` James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1082339577.15101.4.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=eger-dated-1082943669.d79d33@theboonies.us \
--cc=jsimmons@infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).