From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH] radeonfb(): memmove() fix -- this one works ;-) Date: Wed, 28 Apr 2004 09:25:11 +1000 Sender: linux-fbdev-devel-admin@lists.sourceforge.net Message-ID: <1083108311.16476.56.camel@gaston> References: Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.12] helo=sc8-sf-mx2.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1BIc2X-0002SU-P6 for linux-fbdev-devel@lists.sourceforge.net; Tue, 27 Apr 2004 16:31:01 -0700 Received: from gate.crashing.org ([63.228.1.57] ident=root) by sc8-sf-mx2.sourceforge.net with esmtp (TLSv1:AES256-SHA:256) (Exim 4.30) id 1BIc2X-0003wv-BV for linux-fbdev-devel@lists.sourceforge.net; Tue, 27 Apr 2004 16:31:01 -0700 In-Reply-To: Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: List-Post: List-Help: List-Subscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: James Simmons Cc: John Zielinski , David Eger , Geert Uytterhoeven , "Antonino A. Daplas" , eger-dated-1082943669.d79d33@theboonies.us, Linux Fbdev development list On Wed, 2004-04-28 at 09:18, James Simmons wrote: > > a regression from 2.4 and I don't think his patch will be more invasive > > than the rest of the changes you have been doing lately ;) > > > > Face it, the current fbcon resize mecanism is just broken. It cannot > > work properly without full mode management in all drivers. A per-VT var > > along with fbcon properly adapting it's size to the VT's var would bring > > us back to 2.4 level of functionality at least, which is a good thing. > > I refuse to have hacks to deal with a cripple VT system. What is > acceptable is that we add what we need to struct vc_data. You do that and > I have no problem then. From what I can see we need the following. > > 1) Color depth. > 2) Frequency. > 3) Over scan color. No, no, no ... We don't need those, we need a var structure, that's all. > Anything else? > > Personally I rather add these to struct vc_data. Consider if we ever had > hardware that supported different hardware text modes. Say some at > different color depths. I rather do this!! ------------------------------------------------------- This SF.Net email is sponsored by: Oracle 10g Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE. http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click