From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH] radeonfb(): memmove() fix -- this one works ;-) Date: Wed, 28 Apr 2004 09:28:05 +1000 Sender: linux-fbdev-devel-admin@lists.sourceforge.net Message-ID: <1083108484.16544.61.camel@gaston> References: Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.11] helo=sc8-sf-mx1.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1BIc5M-0003CC-Kl for linux-fbdev-devel@lists.sourceforge.net; Tue, 27 Apr 2004 16:33:56 -0700 Received: from gate.crashing.org ([63.228.1.57] ident=root) by sc8-sf-mx1.sourceforge.net with esmtp (TLSv1:AES256-SHA:256) (Exim 4.30) id 1BIc5M-0002V2-95 for linux-fbdev-devel@lists.sourceforge.net; Tue, 27 Apr 2004 16:33:56 -0700 In-Reply-To: Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: List-Post: List-Help: List-Subscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: James Simmons Cc: John Zielinski , David Eger , Geert Uytterhoeven , "Antonino A. Daplas" , eger-dated-1082943669.d79d33@theboonies.us, Linux Fbdev development list On Wed, 2004-04-28 at 09:24, James Simmons wrote: > > No, this would not be for the stable release. But what I'm saying is > > that it's nice that a program cleans up after itself but we shouldn't > > rely on it. Take resources like memory, file handles, sockets, etc. > > Most program release those resources when the shut down normally but > > what if they seg fault or exit unexpectedly? The kernel cleans up after > > the process regardless. > > > > So if a fb program restores the mode properly then we should do nothing > > but if it doesn't either because of a bad programming or an unexpected > > termination then we should reset the mode to what the user has selected > > for their console. > > Trust me. I wish the console would cleanup itself. It would take a good > amount of work to redo. Nah, it's a lot easier to restore the state you need than to save/restore everything. It's not even always possible to save/restore everything (think: write only registers). I got that pretty much working lately with the new blank() argument anyway, though some drivers need to be told about it FB_ACTIVATE_FORCE I suppose. Ben. ------------------------------------------------------- This SF.Net email is sponsored by: Oracle 10g Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE. http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click