From: "Robert T. Johnson" <rtjohnso@eecs.berkeley.edu>
To: viro@parcelfarce.linux.theplanet.co.uk
Cc: linux-fbdev-devel@lists.sourceforge.net,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: PATCH: 2.6.7-rc3 drivers/video/fbmem.c: user/kernel pointer bugs
Date: 09 Jun 2004 22:00:56 -0700 [thread overview]
Message-ID: <1086843656.32057.390.camel@dooby.cs.berkeley.edu> (raw)
In-Reply-To: <20040610041529.GD12308@parcelfarce.linux.theplanet.co.uk>
On Wed, 2004-06-09 at 21:15, viro@parcelfarce.linux.theplanet.co.uk
wrote:
> On Wed, Jun 09, 2004 at 08:50:33PM -0700, Robert T. Johnson wrote:
> > static int pty_write(struct tty_struct * tty, int from_user,
> > const unsigned char __user *ubuf,
> > const unsigned char __kernel *kbuf,
> > int count)
>
> So I suspect that it in the long run the proper fix will be to sanitize
> the locking and move all copy_from_user() to the (only) caller.
I agree this is the ideal fix. I can see advantages and disadvantages
to all the approaches. I'm not familiar with the locking issues, so I
can't comment on that.
> > I fear that completely separating ioctl and kernel data structures would
> > result in lots of redundant structure definitions, which will lead to
> > code maintainence problems and their own host of bugs. Would it be
> > better to just design a bug finding tool that's capable of keeping track
> > of different structure instances separately?
>
> I doubt it. Most of the ioctl data structures do not survive past the
> decoding; fb layer is ugly that way, but that's a local problem and it
> can be fixed.
>
> Keep in mind that anything containing userland pointers needs to be explicitly
> dealt with on 32/64 platforms - otherwise 32bit code won't be able to issue
> that ioctl anyway.
>
> Besides, kernel data structures should not be tied by ABI stability
> requirements - and ioctl arguments have to. Which leads to far worse bug
> potential than explict decoding.
These are design issues outside the scope of what I'm doing, but they
are important. I'll try to keep these considerations in mind as I
continue to improve cqual. Thanks for the helpful feedback.
Best,
Rob
-------------------------------------------------------
This SF.Net email is sponsored by: GNOME Foundation
Hackers Unite! GUADEC: The world's #1 Open Source Desktop Event.
GNOME Users and Developers European Conference, 28-30th June in Norway
http://2004/guadec.org
next prev parent reply other threads:[~2004-06-10 5:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-09 22:46 PATCH: 2.6.7-rc3 drivers/video/fbmem.c: user/kernel pointer bugs Robert T. Johnson
2004-06-10 1:24 ` viro
2004-06-10 3:50 ` Robert T. Johnson
2004-06-10 4:15 ` viro
2004-06-10 5:00 ` Robert T. Johnson [this message]
2004-06-10 9:15 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1086843656.32057.390.camel@dooby.cs.berkeley.edu \
--to=rtjohnso@eecs.berkeley.edu \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).