From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kronos <kronos@people.it>
Cc: John Zielinski <grim@undead.cc>,
Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: radeon_pm.c locking problem
Date: Mon, 05 Jul 2004 08:44:53 -0500 [thread overview]
Message-ID: <1089035092.3014.7.camel@gaston> (raw)
In-Reply-To: <20040702185241.GA25832@dreamland.darkstar.lan>
> is expanded in:
>
> do {
> unsigned long flags;
> spin_lock_irqsave(&rinfo->reg_lock, flags);
> __OUTPLL(pllPIXCLKS_CNTL, INPLL(pllPIXCLKS_CNTL) & ~PIXCLKS_CNTL__PIX2CLK_SRC_SEL_MASK);
> spin_unlock_irqrestore(&rinfo->reg_lock, flags);
> } while(0)
>
> and INPLL will try to reacquire the lock ->reg_lock. We could either use
> __INPLL (which does not take the lock) or make OUTPLL an inline function
> (in this way INPLL is called before entering the function).
Make it an inline function...
Ben.
-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 -
digital self defense, top technical experts, no vendor pitches,
unmatched networking opportunities. Visit www.blackhat.com
next prev parent reply other threads:[~2004-07-05 13:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-02 17:29 radeon_pm.c locking problem John Zielinski
2004-07-02 18:52 ` Kronos
2004-07-05 13:44 ` Benjamin Herrenschmidt [this message]
2004-07-05 16:41 ` Kronos
2004-07-05 21:24 ` David Eger
2004-07-05 22:03 ` Benjamin Herrenschmidt
2004-07-02 20:14 ` David Eger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1089035092.3014.7.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=grim@undead.cc \
--cc=kronos@people.it \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).