Re: patch fixing background next to penguin logo in monochrome

[Petr Stehlik <pstehlik@sophics.cz>]

V Ne, 12. 09. 2004 v 00:16, Antonino A. Daplas pí¹e:
> On Thursday 12 August 2004 03:56, Petr Stehlik wrote:
> > I have developed a simple workaround for a problem existing in
> > framebuffer when it interprets VGA attribute bits in monochrome mode.
> > Instead of empty chars we get underlines

> Anyway, the simplest solution is to use a vc->vc_video_erase_char with the
> underline attribute removed.  Check drivers/video/fbcon.c and look at the
> function fbcon_setup. Note, the logo space is erased using the scr_memsetw
> function with conp->vc_video_erase_char. Just replace them with
> (conp->vc_video_erase_char & ~0x400) if conp->can_do_color is false. (0x400
> is the underline attribute). 

Good idea. Tested, works. Included below.

Thanks.

Petr

Index: drivers/video/fbcon.c
===================================================================
RCS file: /home/linux-m68k/cvsroot/linux/drivers/video/Attic/fbcon.c,v
retrieving revision 1.1.1.2.2.6
diff -u -r1.1.1.2.2.6 fbcon.c
--- drivers/video/fbcon.c	26 Aug 2003 03:13:09 -0000	1.1.1.2.2.6
+++ drivers/video/fbcon.c	12 Aug 2004 11:59:22 -0000
@@ -692,9 +692,13 @@
     		conp->vc_pos += logo_lines * conp->vc_size_row;
     	    }
     	}
-    	scr_memsetw((unsigned short *)conp->vc_origin,
-		    conp->vc_video_erase_char, 
-		    conp->vc_size_row * logo_lines);
+	{
+		int erase_char = conp->vc_video_erase_char;
+		if (! conp->vc_can_do_color)
+			erase_char &= ~0x400; /* disable underline */
+		scr_memsetw((unsigned short *)conp->vc_origin,
+			erase_char, conp->vc_size_row * logo_lines);
+	}
     }
     
     /*




-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285