* [PATCH] fbdev: rivafb I2C timings too fast
@ 2004-09-14 21:53 Antonino A. Daplas
2004-09-14 22:06 ` Nicolas Boichat
0 siblings, 1 reply; 2+ messages in thread
From: Antonino A. Daplas @ 2004-09-14 21:53 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linux Fbdev development list, Nicolas Boichat
The timings in rivafb's i2c, although enough for EDID reading, are too fast
for some user applications. Reported by Nicolas Boichat
<nicolas@boichat.ch>.
This patch increases the timeouts.
Signed-off-by: Antonino Daplas <adaplas@pol.net>
---
rivafb-i2c.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff -uprN linux-2.6.9-rc1-mm5-orig/drivers/video/riva/rivafb-i2c.c linux-2.6.9-rc1-mm5/drivers/video/riva/rivafb-i2c.c
--- linux-2.6.9-rc1-mm5-orig/drivers/video/riva/rivafb-i2c.c 2004-09-13 19:50:17.000000000 +0800
+++ linux-2.6.9-rc1-mm5/drivers/video/riva/rivafb-i2c.c 2004-09-15 05:38:19.307344544 +0800
@@ -105,9 +105,8 @@ static int riva_setup_i2c_bus(struct riv
chan->algo.setscl = riva_gpio_setscl;
chan->algo.getsda = riva_gpio_getsda;
chan->algo.getscl = riva_gpio_getscl;
- chan->algo.udelay = 5;
- chan->algo.mdelay = 5;
- chan->algo.timeout = 10;
+ chan->algo.udelay = 40;
+ chan->algo.timeout = 20;
chan->algo.data = chan;
i2c_set_adapdata(&chan->adapter, chan);
-------------------------------------------------------
This SF.Net email is sponsored by: thawte's Crypto Challenge Vl
Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam
Camcorder. More prizes in the weekly Lunch Hour Challenge.
Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-09-14 22:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-14 21:53 [PATCH] fbdev: rivafb I2C timings too fast Antonino A. Daplas
2004-09-14 22:06 ` Nicolas Boichat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).