From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: ajoshi@shell.unixbox.com,
Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@zip.com.au>
Subject: Re: Radeon: do not blank screen during suspend
Date: Sat, 18 Sep 2004 14:47:02 +1000 [thread overview]
Message-ID: <1095482822.3574.24.camel@gaston> (raw)
In-Reply-To: <20040915112652.GA21386@elf.ucw.cz>
On Wed, 2004-09-15 at 21:26, Pavel Machek wrote:
> Hi!
>
> This stops ugly flashing from radeon during suspend/resume, please
> apply,
Shoud be fine.
BTW. What is the status with Patrick merge of pmdisk & swsusp ? Has it
been merged at all ? (No time to check at the moment). I still hope I'll
find some time to do real work on it (& cleanup the ppc support that I
had working experimentally at OLS) sooner or later...
Ben.
Pavel
>
> --- clean-mm/drivers/video/aty/radeon_pm.c 2004-08-24 09:03:18.000000000 +0200
> +++ linux-mm/drivers/video/aty/radeon_pm.c 2004-09-15 13:00:51.000000000 +0200
> @@ -871,7 +871,8 @@
> agp_enable(0);
> #endif
>
> - fb_set_suspend(info, 1);
> + if (system_state != SYSTEM_SNAPSHOT)
> + fb_set_suspend(info, 1);
>
> if (!(info->flags & FBINFO_HWACCEL_DISABLED)) {
> /* Make sure engine is reset */
> @@ -880,12 +881,14 @@
> radeon_engine_idle();
> }
>
> - /* Blank display and LCD */
> - radeonfb_blank(VESA_POWERDOWN, info);
> -
> - /* Sleep */
> - rinfo->asleep = 1;
> - rinfo->lock_blank = 1;
> + if (system_state != SYSTEM_SNAPSHOT) {
> + /* Blank display and LCD */
> + radeonfb_blank(VESA_POWERDOWN, info);
> +
> + /* Sleep */
> + rinfo->asleep = 1;
> + rinfo->lock_blank = 1;
> + }
>
> /* Suspend the chip to D2 state when supported
> */
--
Benjamin Herrenschmidt <benh@kernel.crashing.org>
-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM.
Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php
next prev parent reply other threads:[~2004-09-18 4:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-15 11:26 Radeon: do not blank screen during suspend Pavel Machek
2004-09-18 4:47 ` Benjamin Herrenschmidt [this message]
2004-09-18 10:22 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1095482822.3574.24.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=ajoshi@shell.unixbox.com \
--cc=akpm@zip.com.au \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).