From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: adaplas@pol.net
Cc: Andrew Morton <akpm@osdl.org>,
Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: [PATCH 8/8] fbdev: Fix broken fb_blank() implementation.
Date: Mon, 08 Nov 2004 08:39:41 +1100 [thread overview]
Message-ID: <1099863581.10262.134.camel@gaston> (raw)
In-Reply-To: <200411080526.50550.adaplas@hotpop.com>
On Mon, 2004-11-08 at 05:27 +0800, Antonino A. Daplas wrote:
> This patch fixes some of the drivers' fb_blank() implementation which got
> the usage of the VESA_* constants incorrectly and converts them to use the
> new FB_BLANK-* constants.
>
> I'm not sure if what I did is correct for all drivers, so maintainers,
> please review.
>
> (Note: For most of the drivers, FB_BLANK_NORMAL is treated as
> FB_BLANK_UNBLANK, but returns a nonzero so fbcon wi
I think that on laptops, FB_BLANK_NORMAL could lower the backlight to 0
(without disabling the panel, which requires more time)... I'll look
into this, in the meantime, your patch is fine.
BTW, what is the current status, can we use msleep in blank yet ? I
think we can still have unblank() called by printk at interrupt time
right ? I'd like to msleep in there rather than playing my games with
a timer ...
Ben.
-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click
next prev parent reply other threads:[~2004-11-07 21:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-07 21:27 [PATCH 8/8] fbdev: Fix broken fb_blank() implementation Antonino A. Daplas
2004-11-07 21:39 ` Benjamin Herrenschmidt [this message]
2004-11-07 23:23 ` Antonino A. Daplas
2004-11-07 23:52 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1099863581.10262.134.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=adaplas@pol.net \
--cc=akpm@osdl.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).