From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: Re: [PATCH] fbdev: Fix IO access in rivafb Date: Sun, 14 Nov 2004 10:52:00 +1100 Message-ID: <1100389920.20511.133.camel@gaston> References: <200411080521.iA85LbG6025914@hera.kernel.org> <200411132000.31465.adaplas@hotpop.com> <200411140529.48977.adaplas@hotpop.com> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.12] helo=sc8-sf-mx2.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1CT7hH-0005cX-3j for linux-fbdev-devel@lists.sourceforge.net; Sat, 13 Nov 2004 15:52:47 -0800 Received: from gate.crashing.org ([63.228.1.57]) by sc8-sf-mx2.sourceforge.net with esmtp (TLSv1:AES256-SHA:256) (Exim 4.41) id 1CT7hG-0006yM-J6 for linux-fbdev-devel@lists.sourceforge.net; Sat, 13 Nov 2004 15:52:46 -0800 In-Reply-To: <200411140529.48977.adaplas@hotpop.com> Sender: linux-fbdev-devel-admin@lists.sourceforge.net Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: List-Post: List-Help: List-Subscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: adaplas@pol.net Cc: Linux Fbdev development list , Linus Torvalds , Guido Guenther , Linux Kernel list , Andrew Morton On Sun, 2004-11-14 at 05:29 +0800, Antonino A. Daplas wrote: > On Sunday 14 November 2004 02:00, Linus Torvalds wrote: > > On Sat, 13 Nov 2004, Antonino A. Daplas wrote: > > > Why not use in_be* and out_be* for __raw_read and raw_write? > > > > Please don't start using some stupid magic ppc-specific macros for a > > driver that has no reason to be PPC-specific. It then only causes bugs > > that show on one platform and not another. > > I'm not. I'm just wondering that if the other approach was taken (keep the > hardware in little endian mode), then the write/read* macros, which are just > wrappers for in_le*/out_le*, would have been used. Would it help fix (or > cover up) bugs that are in PPC but not x86? If you switch the HW to LE, I'm afraid you'll lockup when VT switching back & forth with X ... Ben. ------------------------------------------------------- This SF.Net email is sponsored by: InterSystems CACHE FREE OODBMS DOWNLOAD - A multidimensional database that combines robust object and relational technologies, making it a perfect match for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8