Re: [patch] radeonfb: FB_WAITFORVSYNC implementation

["Michel Dänzer" <michel@daenzer.net>]

On Wed, 2005-03-16 at 01:28 +0000, Torgeir Veimo wrote:
> On Sat, 2005-03-12 at 17:13 +0200, Ville Syrjälä wrote:
> > On Sat, Mar 12, 2005 at 02:06:45PM +0000, Torgeir Veimo wrote:
> 
> > > +		/* clear interrupt */
> > > +		//OUTREG(GEN_INT_CNTL, int_cntl | CRTC_VBLANK_STAT_ACK);
> > 
> > Why is this commented out?
> 
> Well, first of all is it really important to clear the interrupt when
> enabling it? 
> 
> From what I've seen the rage128 acknowledges an interrupt by writing to
> the int_cntl register, while the radeon does it by writing to the
> int_status register, so I think the above code is not correct.. 

That's right, so the int_cntl stuff in the interrupt handler is
superfluous?


> I based my code on the matrox fb driver and the atyfb driver. I don't
> have any documentation on the radeon chipsets, so am working on what I
> can gather on the net.

Let me point out again that the DRM has perfectly working code for
this...


-- 
Earthling Michel Dänzer      |     Debian (powerpc), X and DRI developer
Libre software enthusiast    |   http://svcs.affero.net/rm.php?r=daenzer


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id\x14396&op=click