Re: 2.6.12-rc3 compile failure in tgafb.c

Re: 2.6.12-rc3 compile failure in tgafb.c

[Adrian Bunk]

On Thu, Apr 21, 2005 at 09:50:34PM +0300, Tomi Lapinlampi wrote:
> 
> Hi,
> 
> 2.6.12-rc3 compile fails in drivers/video/tgafb.c
> 
> The system is an Alphastation 600 5/266, system variant Alcor,
> running Debian Sarge, gcc version 3.3.5 (Debian 1:3.3.5-8)
> 
> Btw, the tgafb hasn't really worked on this hardware since 2.6.8.1.
> I'll be able to run more tests after this one compiles :)
> 
> Regards,
> 
> Tomi
> 
> % make
>   CHK     include/linux/version.h
> make[1]: `arch/alpha/kernel/asm-offsets.s' is up to date.
>   CHK     include/asm-alpha/asm_offsets.h
>   CHK     include/linux/compile.h
>   CHK     usr/initramfs_list
>   CC      drivers/video/tgafb.o
> drivers/video/tgafb.c:85: error: `tgafb_pci_unregister' undeclared here (not in a function)
> drivers/video/tgafb.c:85: error: initializer element is not constant
> drivers/video/tgafb.c:85: error: (near initialization for `tgafb_driver.remove')
> make[2]: *** [drivers/video/tgafb.o] Error 1
> make[1]: *** [drivers/video] Error 2
> make: *** [drivers] Error 2
>...

The untested patch below should fix this compile error.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.12-rc2-mm3-full/drivers/video/tgafb.c.old	2005-04-21 22:38:42.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/video/tgafb.c	2005-04-21 22:39:36.000000000 +0200
@@ -45,9 +45,7 @@
 static void tgafb_copyarea(struct fb_info *, const struct fb_copyarea *);
 
 static int tgafb_pci_register(struct pci_dev *, const struct pci_device_id *);
-#ifdef MODULE
 static void tgafb_pci_unregister(struct pci_dev *);
-#endif
 
 static const char *mode_option = "640x480@60";
 
@@ -1484,7 +1482,6 @@
 	return ret;
 }
 
-#ifdef MODULE
 static void __exit
 tgafb_pci_unregister(struct pci_dev *pdev)
 {
@@ -1500,6 +1497,7 @@
 	kfree(info);
 }
 
+#ifdef MODULE
 static void __exit
 tgafb_exit(void)
 {



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

Re: 2.6.12-rc3 compile failure in tgafb.c

[Tomi Lapinlampi]

On Thu, Apr 21, 2005 at 10:43:54PM +0200, Adrian Bunk wrote:
> On Thu, Apr 21, 2005 at 09:50:34PM +0300, Tomi Lapinlampi wrote:
> > 
> > Hi,
> > 
> > 2.6.12-rc3 compile fails in drivers/video/tgafb.c
> > 
> > The system is an Alphastation 600 5/266, system variant Alcor,
> > running Debian Sarge, gcc version 3.3.5 (Debian 1:3.3.5-8)
> > 
> > Btw, the tgafb hasn't really worked on this hardware since 2.6.8.1.
> > I'll be able to run more tests after this one compiles :)
> > 
> > Regards,
> > 
> > Tomi
> > 
> > % make
> >   CHK     include/linux/version.h
> > make[1]: `arch/alpha/kernel/asm-offsets.s' is up to date.
> >   CHK     include/asm-alpha/asm_offsets.h
> >   CHK     include/linux/compile.h
> >   CHK     usr/initramfs_list
> >   CC      drivers/video/tgafb.o
> > drivers/video/tgafb.c:85: error: `tgafb_pci_unregister' undeclared here (not in a function)
> > drivers/video/tgafb.c:85: error: initializer element is not constant
> > drivers/video/tgafb.c:85: error: (near initialization for `tgafb_driver.remove')
> > make[2]: *** [drivers/video/tgafb.o] Error 1
> > make[1]: *** [drivers/video] Error 2
> > make: *** [drivers] Error 2
> >...
> 
> The untested patch below should fix this compile error.

Hi,

This patch worked, tgafb.c now compiles. However, the compile
fails later:

...
  CC      init/version.o
  LD      init/built-in.o
  LD      .tmp_vmlinux1
local symbol 0: discarded in section `.exit.text' from drivers/built-in.o
make: *** [.tmp_vmlinux1] Error 1

This does not happen if I disable CONFIG_FB_TGA.

Tomi


> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> --- linux-2.6.12-rc2-mm3-full/drivers/video/tgafb.c.old	2005-04-21 22:38:42.000000000 +0200
> +++ linux-2.6.12-rc2-mm3-full/drivers/video/tgafb.c	2005-04-21 22:39:36.000000000 +0200
> @@ -45,9 +45,7 @@
>  static void tgafb_copyarea(struct fb_info *, const struct fb_copyarea *);
>  
>  static int tgafb_pci_register(struct pci_dev *, const struct pci_device_id *);
> -#ifdef MODULE
>  static void tgafb_pci_unregister(struct pci_dev *);
> -#endif
>  
>  static const char *mode_option = "640x480@60";
>  
> @@ -1484,7 +1482,6 @@
>  	return ret;
>  }
>  
> -#ifdef MODULE
>  static void __exit
>  tgafb_pci_unregister(struct pci_dev *pdev)
>  {
> @@ -1500,6 +1497,7 @@
>  	kfree(info);
>  }
>  
> +#ifdef MODULE
>  static void __exit
>  tgafb_exit(void)
>  {
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
You can decide: live with free software or with only one evil company left?

Re: 2.6.12-rc3 compile failure in tgafb.c

[Tomi Lapinlampi]

On Fri, Apr 22, 2005 at 10:28:58AM +0300, Tomi Lapinlampi wrote:

> Hi,
> 
> This patch worked, tgafb.c now compiles. However, the compile
> fails later:
> 
> ...
>   CC      init/version.o
>   LD      init/built-in.o
>   LD      .tmp_vmlinux1
> local symbol 0: discarded in section `.exit.text' from drivers/built-in.o
> make: *** [.tmp_vmlinux1] Error 1
> 
> This does not happen if I disable CONFIG_FB_TGA.

Actually, I was able to get a clean compile with the patch from
http://marc.theaimsgroup.com/?l=linux-alpha&m=111392038121433&w=2

Which one is better, this or the one that Adrian sent?

Tomi

> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > 
> > --- linux-2.6.12-rc2-mm3-full/drivers/video/tgafb.c.old	2005-04-21 22:38:42.000000000 +0200
> > +++ linux-2.6.12-rc2-mm3-full/drivers/video/tgafb.c	2005-04-21 22:39:36.000000000 +0200
> > @@ -45,9 +45,7 @@
> >  static void tgafb_copyarea(struct fb_info *, const struct fb_copyarea *);
> >  
> >  static int tgafb_pci_register(struct pci_dev *, const struct pci_device_id *);
> > -#ifdef MODULE
> >  static void tgafb_pci_unregister(struct pci_dev *);
> > -#endif
> >  
> >  static const char *mode_option = "640x480@60";
> >  
> > @@ -1484,7 +1482,6 @@
> >  	return ret;
> >  }
> >  
> > -#ifdef MODULE
> >  static void __exit
> >  tgafb_pci_unregister(struct pci_dev *pdev)
> >  {
> > @@ -1500,6 +1497,7 @@
> >  	kfree(info);
> >  }
> >  
> > +#ifdef MODULE
> >  static void __exit
> >  tgafb_exit(void)
> >  {
> > 
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> 
> -- 
> You can decide: live with free software or with only one evil company left?
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
You can decide: live with free software or with only one evil company left?

Re: 2.6.12-rc3 compile failure in tgafb.c, tgafb not working anymore

[Tomi Lapinlampi]

On Fri, Apr 22, 2005 at 02:20:30PM +0300, Tomi Lapinlampi wrote:
> 
> Actually, I was able to get a clean compile with the patch from
> http://marc.theaimsgroup.com/?l=linux-alpha&m=111392038121433&w=2

Hi again,

Although the tgafb driver compiles with the above patch, it shows
similar behaviour as before: The kernel loads, the monitor comes alive
but the screen stays completely blank.
The last kernel that worked was 2.6.8.1. I've tested with 2.6.{9,10,11}

Here's more info on the system... The dmesg entry (booting with serial console)

Linux version 2.6.12-rc3 (lapinlam@raato) (gcc version 3.3.5 (Debian 1:3.35
Booting on Alcor variation Alcor using machine vector Alcor from MILO
Major Options: LEGACY_START VERBOSE_MCHECK MAGIC_SYSRQ
Command line: ro root=/dev/sdb1 console=ttyS0,38400n8
memcluster 0, usage 1, start        0, end      161
memcluster 1, usage 0, start      161, end    32651
memcluster 2, usage 1, start    32651, end    32768
freeing pages 161:384
freeing pages 838:32651
reserving pages 838:839
2048K Bcache detected; load hit latency 24 cycles, load miss latency 88 cycles
pci: cia revision 1
Built 1 zonelists
Kernel command line: ro root=/dev/sdb1 console=ttyS0,38400n8
PID hash table entries: 1024 (order: 10, 32768 bytes)
Using epoch = 2000
Console: colour dummy device 80x25
Dentry cache hash table entries: 65536 (order: 6, 524288 bytes)
Inode-cache hash table entries: 32768 (order: 5, 262144 bytes)
Memory: 253320k/261208k available (2077k kernel code, 6264k reserved, 683k data)
Mount-cache hash table entries: 512
NET: Registered protocol family 16
EISA bus registered
pci: passed tb register update test
pci: passed sg loopback i/o read test
pci: passed tbia test
pci: passed pte write cache snoop test
pci: failed valid tag invalid pte reload test (mcheck; workaround available)
pci: passed pci machine check test
PCI: Bridge: 0000:00:08.0
  IO window: 9000-9fff
  MEM window: 02200000-022fffff
  PREFETCH window: disabled.
PCI: Bridge: 0000:00:09.0
  IO window: disabled.
  MEM window: 02400000-027fffff
  PREFETCH window: disabled.
Linux Plug and Play Support v0.97 (c) Adam Belay
SCSI subsystem initialized
TC classifier action (bugs to netdev@oss.sgi.com cc hadi@cyberus.ca)
Initializing Cryptographic API
Console: switching to colour frame buffer device 80x30
tgafb: DC21030 [TGA] detected, rev=0x03
tgafb: at PCI bus 0, device 7, function 0
fb0: Digital ZLXp-E1 frame buffer device at 0x8000000
isapnp: Scanning for PnP cards...
isapnp: No Plug & Play device found
rtc: SRM (post-2000) epoch (2000) detected
Real Time Clock Driver v1.12
Serial: 8250/16550 driver $Revision: 1.90 $ 8 ports, IRQ sharing disabled
ttyS0 at I/O 0x3f8 (irq = 4) is a 16550A
ttyS1 at I/O 0x2f8 (irq = 3) is a 16550A
io scheduler noop registered
io scheduler anticipatory registered
io scheduler deadline registered
io scheduler cfq registered

.....

lspci -v -v for the display adapter:

0000:00:07.0 Display controller: Digital Equipment Corporation DECchip 21030 [TGA] (rev 03)
        Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping+ SERR- FastB2B-
        Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
        Latency: 255
        Interrupt: pin A routed to IRQ 24
        Region 0: Memory at 0000000008000000 (32-bit, prefetchable) [size=128M]
        Expansion ROM at 0000000002300000 [disabled] [size=256K]

Any clues? It would be nice to get this working again. I'm willing to
test any patches you might have :)

Tomi

-- 
You can decide: live with free software or with only one evil company left?

Re: 2.6.12-rc3 compile failure in tgafb.c, tgafb not working anymore

[Linus Torvalds]

On Fri, 22 Apr 2005, Tomi Lapinlampi wrote:
> 
> Although the tgafb driver compiles with the above patch, it shows
> similar behaviour as before: The kernel loads, the monitor comes alive
> but the screen stays completely blank.
> The last kernel that worked was 2.6.8.1. I've tested with 2.6.{9,10,11}

Can you try to figure out where in between 2.6.8->2.6.9 things broke? Even 
just a fairly simple binary search on the nightly snapshots should get you 
pretty easily down to within one day or so..

Most people don't have tga hardware. I don't think even most alpha users 
have it, and I think it's unheard of outside of alpha. So I'm afraid that 
there's not a lot of people around who can debug it without having a very 
clear starting point..

		Linus


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

Re: 2.6.12-rc3 compile failure in tgafb.c, tgafb not working anymore

[Maciej W. Rozycki]

On Fri, 22 Apr 2005, Linus Torvalds wrote:

> Most people don't have tga hardware. I don't think even most alpha users 
> have it, and I think it's unheard of outside of alpha. So I'm afraid that 
> there's not a lot of people around who can debug it without having a very 
> clear starting point..

 JFTR, a few of the TURBOchannel variations of the TGA are supported for 
MIPS, but regrettably the necessary code hasn't been ported from 2.4 to 
2.6 yet.

  Maciej


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

Re: 2.6.12-rc3 compile failure in tgafb.c, tgafb not working anymore

[Linus Torvalds]

On Fri, 22 Apr 2005, Maciej W. Rozycki wrote:
> 
>  JFTR, a few of the TURBOchannel variations of the TGA are supported for 
> MIPS, but regrettably the necessary code hasn't been ported from 2.4 to 
> 2.6 yet.

Ok, so that would have increased the testing base by, what? One person or 
two? I think we're still in single digits ;)

			Linus


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

Re: 2.6.12-rc3 compile failure in tgafb.c, tgafb not working anymore

[Maciej W. Rozycki]

On Fri, 22 Apr 2005, Linus Torvalds wrote:

> >  JFTR, a few of the TURBOchannel variations of the TGA are supported for 
> > MIPS, but regrettably the necessary code hasn't been ported from 2.4 to 
> > 2.6 yet.
> 
> Ok, so that would have increased the testing base by, what? One person or 
> two? I think we're still in single digits ;)

 Except that once I get them running with 2.6 I'll try keeping an eye on 
the driver so that nothing gets broken at least for the more useful 
configurations. 8-)

  Maciej


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

Re: Re: 2.6.12-rc3 compile failure in tgafb.c, tgafb not working anymore

[Geert Uytterhoeven]

On Fri, 22 Apr 2005, Linus Torvalds wrote:
> On Fri, 22 Apr 2005, Maciej W. Rozycki wrote:
> >  JFTR, a few of the TURBOchannel variations of the TGA are supported for 
> > MIPS, but regrettably the necessary code hasn't been ported from 2.4 to 
> > 2.6 yet.
> 
> Ok, so that would have increased the testing base by, what? One person or 
> two? I think we're still in single digits ;)

All the DEC UDB (`Multia') machines have builtin TGA.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

Re: Re: 2.6.12-rc3 compile failure in tgafb.c, tgafb not working anymore

[Thomas Jahns]

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

Hi,

On 04/22/05 21:51:34, Geert Uytterhoeven wrote:
> On Fri, 22 Apr 2005, Linus Torvalds wrote:
> > Ok, so that would have increased the testing base by, what? One
> > person or two? I think we're still in single digits ;)
> 
> All the DEC UDB (`Multia') machines have builtin TGA.

most Alphastation 200 machines came with a TGA card installed.

Thomas Jahns
-- 
"Computers are good at following instructions,
  but not at reading your mind."
D. E. Knuth, The TeXbook, Addison-Wesley 1984, 1986, 1996, p. 9

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: 2.6.12-rc3 compile failure in tgafb.c, tgafb not working anymore

[Antonino A. Daplas]

On Friday 22 April 2005 22:40, Tomi Lapinlampi wrote:
> On Fri, Apr 22, 2005 at 02:20:30PM +0300, Tomi Lapinlampi wrote:
> > Actually, I was able to get a clean compile with the patch from
> > http://marc.theaimsgroup.com/?l=linux-alpha&m=111392038121433&w=2
>
> Hi again,
>
> Although the tgafb driver compiles with the above patch, it shows
> similar behaviour as before: The kernel loads, the monitor comes alive
> but the screen stays completely blank.
> The last kernel that worked was 2.6.8.1. I've tested with 2.6.{9,10,11}

What does fbset show?  If the line rgba shows all zero, then you will get a
blank screen. The driver must properly set info->var.green|red|blue|transp,
which in turn depends on the hardware configuration.

You can try to insert these in tgafb_pci_register() after fb_find_mode().

If at 8bpp pseudocolor:

all->info.var.green.length = 8;
all->info.var.red.length = 8;
all->info.var.blue.length = 8;
all->info.var.green.offset = 0;
all->info.var.red.offset = 0;
all->info.var.blue.offset = 0;

If at 32-bit truecolor:

all->info.var.green.length = 8;
all->info.var.red.length = 8;
all->info.var.blue.length = 8;
all->info.var.green.offset = 8;
all->info.var.red.offset = 16;
all->info.var.blue.offset = 0;

If the above changes work, a definitive fix is still needed, one that will
also set the above for each visual the hardware supports on each
fb_check_var().

Tony




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click