Re: Re: [patch 1/1] delete unused file

[Thomas Jahns <Thomas.Jahns@gmx.net>]

[-- Attachment #1: Type: text/plain, Size: 1957 bytes --]

Hi,

On 01/09/05 22:15:50, Antonino A. Daplas wrote:
> On Sunday 26 December 2004 23:13, domen@coderock.org wrote:
> > Remove nowhere referenced file. (egrep "filename\." didn't find
> > anything)
> 
> This file is now being used for BIOS-less booting of Rage XL cards in
> 2.6.10-mm1.

I had this file accidentally selected when building a 2.6.11.6 kernel 
from debians kernel-source-2.6.11, 2.6.11-3 version package for my 
PowerMac G3, all of:

FB_ATY
FB_ATY_CT
FB_ATY_XL_INIT
FB_ATY_GX

but not

FB_ATY_GENERIC_LCD

where selected, accordingly the build failed because of a missing 
symbol: aty_st_lcd
aty_st_lcd is called in line 256 of xlinit.c but perhaps should be 
surrounded by an ifdef like its declaration in atyfb.h and definition 
in atyfb_base.c:

#if defined(CONFIG_PM) || defined(CONFIG_PMAC_BACKLIGHT) || defined
(CONFIG_FB_ATY_GENERIC_LCD)
extern void aty_st_lcd(int index, u32 val, const struct atyfb_par *par);
extern u32 aty_ld_lcd(int index, const struct atyfb_par *par);
#endif

This is just a report of a problem I faced because I had FB_ATY_XL_INIT
activated, although I don't really need it. Therefore I'm currently
using a kernel built without FB_ATY_XL_INIT defined (the kernel thus
produced does work on my system, I guess therefore, that the problem
described by Mikael Pettersson does only affect the first generation
beige PowerMac G3 (my system is of 2nd revision).

OTOH: This kernel does, with the exact same arguments to the kernel,
boot with another video timing than the 2.6.9 kernel I used until now.
This is an improvement because the old kernel selected the mode
1024x768-24@60 while 1024x768-24@75 was requested. The 2.6.11 kernel
doesn't select a perfect match either (it's using 1024x768-24@76).

Thomas Jahns
-- 
"Computers are good at following instructions,
 but not at reading your mind."
D. E. Knuth, The TeXbook, Addison-Wesley 1984, 1986, 1996, p. 9


[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]