From: Alexander Stein <alexander.stein@systec-electronic.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v3] video: mx3fb: Add backlight control support
Date: Mon, 12 May 2014 06:17:19 +0000 [thread overview]
Message-ID: <11210402.Xc9TuleuM4@ws-stein> (raw)
In-Reply-To: <1399559916-15183-1-git-send-email-alexander.stein@systec-electronic.com>
On Friday 09 May 2014 12:11:29, Tomi Valkeinen wrote:
> On 08/05/14 17:38, Alexander Stein wrote:
> > This patch add backlight control support to allow dimming the backlight
> > using the internal PWM. Currently the brightness is set fixed to a
> > maximum of 255.
> >
> > Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> > ---
> > Changes in v3:
> > * Add a more descriptive commit message
> >
> > Changes in v2:
> > * rebased to v3.15-rc4
> >
> > drivers/video/fbdev/mx3fb.c | 98 +++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 98 insertions(+)
> >
> > diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c
> > index 142e860..10a7244 100644
> > --- a/drivers/video/fbdev/mx3fb.c
> > +++ b/drivers/video/fbdev/mx3fb.c
> > @@ -27,6 +27,7 @@
> > #include <linux/clk.h>
> > #include <linux/mutex.h>
> > #include <linux/dma/ipu-dma.h>
> > +#include <linux/backlight.h>
> >
> > #include <linux/platform_data/dma-imx.h>
> > #include <linux/platform_data/video-mx3fb.h>
> > @@ -34,6 +35,12 @@
> > #include <asm/io.h>
> > #include <asm/uaccess.h>
> >
> > +#if defined(CONFIG_BACKLIGHT_CLASS_DEVICE) || \
> > + (defined(CONFIG_BACKLIGHT_CLASS_DEVICE_MODULE) && \
> > + defined(CONFIG_MX3FB_MODULE))
> > +#define PWM_BACKLIGHT_AVAILABLE
> > +#endif
>
> I'm not very fond of this kind of ifdeffery. It makes the driver rather
> messy and confusing, especially if large blocks of code are inside the
> ifdefs.
>
> Can't you just make the driver select BACKLIGHT_CLASS_DEVICE?
Well, sure I can. I just went the same way as atmel_lcdfb.c did. Will sent new patch.
Regards,
Alexander
--
Dipl.-Inf. Alexander Stein
SYS TEC electronic GmbH
Am Windrad 2
08468 Heinsdorfergrund
Tel.: 03765 38600-1156
Fax: 03765 38600-4100
Email: alexander.stein@systec-electronic.com
Website: www.systec-electronic.com
Managing Director: Dipl.-Phys. Siegmar Schmidt
Commercial registry: Amtsgericht Chemnitz, HRB 28082
prev parent reply other threads:[~2014-05-12 6:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 14:38 [PATCH v3] video: mx3fb: Add backlight control support Alexander Stein
2014-05-09 9:11 ` Tomi Valkeinen
2014-05-12 6:17 ` Alexander Stein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11210402.Xc9TuleuM4@ws-stein \
--to=alexander.stein@systec-electronic.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).