From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: linux-fbdev-devel@lists.sourceforge.net, adaplas@pol.net,
akpm <akpm@osdl.org>
Subject: Re: [PATCH] radeonfb section mismatches
Date: Sun, 16 Apr 2006 06:27:02 +1000 [thread overview]
Message-ID: <1145132822.4233.0.camel@localhost.localdomain> (raw)
In-Reply-To: <20060414212530.0140b70f.rdunlap@xenotime.net>
On Fri, 2006-04-14 at 21:25 -0700, Randy.Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Marking radeon_pci_register() as __devinit clears up all section
> mismatch warnings that are caused by radeon_pci_register() calling
> various __devinit function. Is there some reason not to do this?
Looks ok to me
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> drivers/video/aty/radeon_base.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2617-rc1g8.orig/drivers/video/aty/radeon_base.c
> +++ linux-2617-rc1g8/drivers/video/aty/radeon_base.c
> @@ -2265,7 +2265,7 @@ static struct bin_attribute edid2_attr =
> };
>
>
> -static int radeonfb_pci_register (struct pci_dev *pdev,
> +static int __devinit radeonfb_pci_register (struct pci_dev *pdev,
> const struct pci_device_id *ent)
> {
> struct fb_info *info;
>
>
> ---
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
prev parent reply other threads:[~2006-04-15 20:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-15 4:25 [PATCH] radeonfb section mismatches Randy.Dunlap
2006-04-15 20:27 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1145132822.4233.0.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=adaplas@pol.net \
--cc=akpm@osdl.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).