[PATCH] radeonfb section mismatches

[PATCH] radeonfb section mismatches

[Randy.Dunlap]

From: Randy Dunlap <rdunlap@xenotime.net>

Marking radeon_pci_register() as __devinit clears up all section
mismatch warnings that are caused by radeon_pci_register() calling
various __devinit function.  Is there some reason not to do this?

WARNING: drivers/video/aty/radeonfb.o - Section mismatch: reference to .init.text: from .text.radeonfb_pci_register after 'radeonfb_pci_register' (at offset 0x628)
WARNING: drivers/video/aty/radeonfb.o - Section mismatch: reference to .init.text: from .text.radeonfb_pci_register after 'radeonfb_pci_register' (at offset 0x6b5)
WARNING: drivers/video/aty/radeonfb.o - Section mismatch: reference to .init.text: from .text.radeonfb_pci_register after 'radeonfb_pci_register' (at offset 0x6bd)
WARNING: drivers/video/aty/radeonfb.o - Section mismatch: reference to .init.text:radeon_probe_screens from .text.radeonfb_pci_register after 'radeonfb_pci_register' (at offset 0x7d6)
WARNING: drivers/video/aty/radeonfb.o - Section mismatch: reference to .init.text:radeon_check_modes from .text.radeonfb_pci_register after 'radeonfb_pci_register' (at offset 0x7e5)

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
 drivers/video/aty/radeon_base.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

--- linux-2617-rc1g8.orig/drivers/video/aty/radeon_base.c
+++ linux-2617-rc1g8/drivers/video/aty/radeon_base.c
@@ -2265,7 +2265,7 @@ static struct bin_attribute edid2_attr =
 };
 
 
-static int radeonfb_pci_register (struct pci_dev *pdev,
+static int __devinit radeonfb_pci_register (struct pci_dev *pdev,
 				  const struct pci_device_id *ent)
 {
 	struct fb_info *info;


---


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642

Re: [PATCH] radeonfb section mismatches

[Benjamin Herrenschmidt]

On Fri, 2006-04-14 at 21:25 -0700, Randy.Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> Marking radeon_pci_register() as __devinit clears up all section
> mismatch warnings that are caused by radeon_pci_register() calling
> various __devinit function.  Is there some reason not to do this?

Looks ok to me

> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

> ---
>  drivers/video/aty/radeon_base.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2617-rc1g8.orig/drivers/video/aty/radeon_base.c
> +++ linux-2617-rc1g8/drivers/video/aty/radeon_base.c
> @@ -2265,7 +2265,7 @@ static struct bin_attribute edid2_attr =
>  };
>  
> 
> -static int radeonfb_pci_register (struct pci_dev *pdev,
> +static int __devinit radeonfb_pci_register (struct pci_dev *pdev,
>  				  const struct pci_device_id *ent)
>  {
>  	struct fb_info *info;
> 
> 
> ---



-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642