From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: Fwd: [Suspend-devel] resume not working on acer ferrari 4005 with radeonfb enabled Date: Wed, 15 Nov 2006 12:48:27 +1100 Message-ID: <1163555308.5940.177.camel@localhost.localdomain> References: <200611142247.55137.chrmhoffmann@gmail.com> <1163542033.5940.156.camel@localhost.localdomain> <200611150154.39499.chrmhoffmann@gmail.com> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1Gk9tE-00065u-W1 for linux-fbdev-devel@lists.sourceforge.net; Tue, 14 Nov 2006 17:48:39 -0800 Received: from gate.crashing.org ([63.228.1.57] ident=[U2FsdGVkX19bYp3O7Qp2bdGLpJopyhOo7GoGq3DAS3E=]) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1Gk9tE-0006G2-Fc for linux-fbdev-devel@lists.sourceforge.net; Tue, 14 Nov 2006 17:48:36 -0800 In-Reply-To: <200611150154.39499.chrmhoffmann@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-fbdev-devel-bounces@lists.sourceforge.net Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net To: Christian Hoffmann Cc: Andrew Morton , linux-fbdev-devel@lists.sourceforge.net, Christian Hoffmann , LKML , "Rafael J. Wysocki" , Solomon Peachy , Pavel Machek On Wed, 2006-11-15 at 01:54 +0100, Christian Hoffmann wrote: > On Tuesday 14 November 2006 23:07, Benjamin Herrenschmidt wrote: > > > I tried that patch, but the last message I see over netconsole (using > > > tg3) is: Suspending console(s) > > > and then nothing. Nothing on resume at all :( > > > > > > Adding some printks in the radeonfb_pci_suspend and radeonfb_pci_resume > > > (radeon_pm.c) didn't help: I don't see them. But I am not a kernel > > > programmer at all, so I might do something wrong or in the wrong place. > > > > Does it resume if you make radeon_pci_resume() a nop ? > > > > Of course, the fbdev will not come back, but will the machine overall > > resume ? > > > > Ben. > Yes, if i make radeon_pci_resume a nop, the machine resumes if i do a return 0 > immediately. > I think I tracked it down to the call to acquire_console_sem() as the > following code makes the machine hang again: > > int radeonfb_pci_resume(struct pci_dev *pdev) > { > struct fb_info *info = pci_get_drvdata(pdev); > struct radeonfb_info *rinfo = info->par; > int rc = 0; > if (pdev->dev.power.power_state.event == PM_EVENT_ON) > return 0; > if (rinfo->no_schedule) { > /* if (try_acquire_console_sem())*/ > return 0; > } else > acquire_console_sem(); > > return 0; > ... Well, if you acquire the console sem you need to release it too :-) Ben. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV