From: Arjan van de Ven <arjan@infradead.org>
To: Ben Dooks <ben-fbdev@fluff.org>
Cc: linux-kernel@vger.kernel.org, linux-fbdev-devel@lists.sourceforge.net
Subject: Re: SM501: core (mfd) driver
Date: Wed, 13 Dec 2006 20:04:06 +0100 [thread overview]
Message-ID: <1166036646.27217.870.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20061213175143.GA11394@home.fluff.org>
On Wed, 2006-12-13 at 17:51 +0000, Ben Dooks wrote:
> > > +
> > > + writel(mode, sm->regs + SM501_POWER_MODE_CONTROL);
> > > +
> > > + dev_dbg(sm->dev, "gate %08lx, clock %08lx, mode %08lx\n",
> > > + gate, clock, mode);
> > > +
> > > + msleep(16);
> >
> > you're missing a PCI posting flush here
> > (if you don't know what this is please ask)
>
> Is this a read from an device register to cause the PCI writes
> to happen?
yup
> Would reading SM501_POWER_MODE_CONTROL be ok, or does
> it require a different register?
any register is ok, you can read the same one just fine.
greetings,
Arjan van de Ven
--
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org
prev parent reply other threads:[~2006-12-13 19:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-13 15:51 SM501: core (mfd) driver Ben Dooks
2006-12-13 17:21 ` Arjan van de Ven
2006-12-13 17:51 ` Ben Dooks
2006-12-13 19:04 ` Arjan van de Ven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1166036646.27217.870.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=ben-fbdev@fluff.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).