From: "Antonino A. Daplas" <adaplas@gmail.com>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: Richard Purdie <rpurdie@rpsys.net>,
linux-kernel@vger.kernel.org,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Jiri Kosina <jikos@jikos.cz>
Subject: Re: 2.6.21-rc1 dims my LCD
Date: Tue, 27 Feb 2007 01:13:59 +0800 [thread overview]
Message-ID: <1172510039.7101.3.camel@daplas> (raw)
In-Reply-To: <1172504617.5824.102.camel@localhost.localdomain>
On Mon, 2007-02-26 at 15:43 +0000, Richard Purdie wrote:
> On Mon, 2007-02-26 at 16:24 +0100, Jiri Kosina wrote:
> > On Mon, 26 Feb 2007, Richard Purdie wrote:
> >
> > > Jiri: I've appended a patch that should already be queued, could you
> > > test and see if it solves the problem.
> >
> > Thanks. In the meantime I have gone through the code and I can confirm
> > that this is the root cause of what I am observing.
> >
> > Now regarding the patch - at the time when the dim happened previously,
> > currently there is a observable blink (after which the brightness is
> > correct).
>
> The reason for the behaviour is that its turning the backlight down/off
> to save power as it thinks the screen is blank. The blink therefore
> makes sense as far as the backlight class is concerned and its working
> as intended now.
>
> > I have put some debugging printk() into fb_notifier_callback(),
> > and it turns out that on FB_EVENT_CONBLANK, there are two successive calls
> > to backlight_update_status(), second immediately following the first one:
> >
> > Feb 26 15:11:14 thunder kernel: calling backlight_update_status() with bd->props.fb_blank == 1, bd->props.brightness == 0
> > Feb 26 15:11:14 thunder kernel: calling backlight_update_status() with bd->props.fb_blank == 0, bd->props.brightness == 0
> >
> > Is this really a right thing to do?
Well, no, the console should not blank and immediately unblank. Of
course, the console can blank after some time and can be induced to
unblank after a keyboard event, for example.
Besides the debugging printk's, can you also add something like
WARN_ON(1); so you can get a tracing too.
Tony
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
prev parent reply other threads:[~2007-02-26 17:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.64.0702260154460.10496@twin.jikos.cz>
[not found] ` <1172490091.5824.30.camel@localhost.localdomain>
[not found] ` <Pine.LNX.4.64.0702261329270.10496@twin.jikos.cz>
[not found] ` <20070226142157.GA2909@khazad-dum.debian.net>
[not found] ` <1172501357.5824.91.camel@localhost.localdomain>
[not found] ` <Pine.LNX.4.64.0702261617240.10496@twin.jikos.cz>
2007-02-26 15:43 ` 2.6.21-rc1 dims my LCD Richard Purdie
2007-02-26 17:13 ` Antonino A. Daplas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1172510039.7101.3.camel@daplas \
--to=adaplas@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=jikos@jikos.cz \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).