From: Richard Purdie <rpurdie@rpsys.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: James Simmons <jsimmons@infradead.org>,
linux-fbdev-devel@lists.sourceforge.net, romosan@sycorax.lbl.gov,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Linux-fbdev-devel] 2.6.21-rc2 radeon backlight
Date: Fri, 02 Mar 2007 23:40:12 +0000 [thread overview]
Message-ID: <1172878812.11149.207.camel@localhost.localdomain> (raw)
In-Reply-To: <20070302135841.fbfc1e32.akpm@linux-foundation.org>
On Fri, 2007-03-02 at 13:58 -0800, Andrew Morton wrote:
> > @@ -1106,7 +1105,8 @@ config FB_ATY_GX
> >
> > config FB_ATY_BACKLIGHT
> > bool "Support for backlight control"
> > - depends on FB_ATY
> > + depends on FB_ATY && EXPERIMENTAL
> > + select FB_BACKLIGHT
> > default y
> > help
> > Say Y here if you want to control the backlight of your display.
>
> Sorry, but my confidence level on this one is very low. We've had heaps
> and heaps of Kconfig-related build errors in exactly this area. I'd prefer
> that a patch like this one have a lot of testing and review (and a
> changelog?) before we let it near a tree.
Agreed, I can tell from what I've seen so far this will at least break
the PMAC users...
See my proposed patch, if that doesn't work, we should revert the
problematic change.
Richard
next prev parent reply other threads:[~2007-03-02 23:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87ps7uutsk.fsf@sycorax.lbl.gov>
2007-03-02 2:45 ` 2.6.21-rc2 radeon backlight Andrew Morton
2007-03-02 17:24 ` Alex Romosan
2007-03-02 20:29 ` Andrew Morton
2007-03-02 20:35 ` David Miller
2007-03-02 21:01 ` Henrique de Moraes Holschuh
2007-03-02 21:22 ` Alex Romosan
2007-03-02 21:40 ` David Miller
2007-03-02 21:41 ` James Simmons
2007-03-02 21:58 ` Andrew Morton
2007-03-02 23:40 ` Richard Purdie [this message]
2007-03-03 16:23 ` James Simmons
2007-03-02 23:32 ` Richard Purdie
2007-03-03 5:34 ` Alex Romosan
2007-03-03 16:06 ` James Simmons
2007-03-03 16:35 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1172878812.11149.207.camel@localhost.localdomain \
--to=rpurdie@rpsys.net \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jsimmons@infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=romosan@sycorax.lbl.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).