From: Richard Purdie <rpurdie@rpsys.net>
To: James Simmons <jsimmons@infradead.org>
Cc: linux-fbdev-devel@lists.sourceforge.net,
"Antonino A. Daplas" <adaplas@gmail.com>,
Alex Romosan <romosan@sycorax.lbl.gov>,
linux-kernel@vger.kernel.org,
Yaroslav Halchenko <lists@onerussian.com>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: 2.6.21-rc2 radeon backlight
Date: Sat, 03 Mar 2007 16:35:13 +0000 [thread overview]
Message-ID: <1172939714.5942.9.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0703031557570.2901@pentafluge.infradead.org>
On Sat, 2007-03-03 at 16:06 +0000, James Simmons wrote:
> > > Richard, is this actually a bug, or is it a config error or something like that?
> > >
> > > And should we track it as a post-2.6.20 regression?
> >
> > Its a regression IMO. Arguably its a Kconfig error but a nasty one as
> > the defaults cause the problems. Different people seem to have different
> > interpretations but to me it appears that the patch from James causes
> > backlights to fail to turn on for a variety of devices which worked
> > before.
>
> It is NOT a Kconfig error. The problem is that for many fbdev drivers
> the backlight code is broken. For some magic reason it only works on
> pmacs. Most likely because the firmware properly sets up the backlight.
> Plus we have the conflict with acpi backlight.
> Think about it. Enabling the backlight code breaks the backlight.
> Without the backlight driver the default behaviour of the backlight works.
> Who sets up the default behavior? I don't have a LCD panel with a
> backlight othewise I would track the problem down.
I not arguing several fb driver's backlight code isn't broken, it is. We
have a Kconfig problem though since we used to stop users selecting
things that didn't work and now we're allowing them. Worse still, the
defaults break for people. That is a regression.
Anyhow, the patch I proposed should let people enable/disable it at
runtime with defaults known to work which should address the problem
until someone figures out how to fix the backlight drivers themselves
properly.
Cheers,
Richard
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
prev parent reply other threads:[~2007-03-03 16:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87ps7uutsk.fsf@sycorax.lbl.gov>
2007-03-02 2:45 ` 2.6.21-rc2 radeon backlight Andrew Morton
2007-03-02 17:24 ` Alex Romosan
2007-03-02 20:29 ` Andrew Morton
2007-03-02 20:35 ` David Miller
2007-03-02 21:01 ` Henrique de Moraes Holschuh
2007-03-02 21:22 ` Alex Romosan
2007-03-02 21:40 ` David Miller
2007-03-02 21:41 ` James Simmons
2007-03-02 21:58 ` Andrew Morton
2007-03-02 23:40 ` [Linux-fbdev-devel] " Richard Purdie
2007-03-03 16:23 ` James Simmons
2007-03-02 23:32 ` Richard Purdie
2007-03-03 5:34 ` Alex Romosan
2007-03-03 16:06 ` James Simmons
2007-03-03 16:35 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1172939714.5942.9.camel@localhost.localdomain \
--to=rpurdie@rpsys.net \
--cc=adaplas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=hmh@hmh.eng.br \
--cc=jsimmons@infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@onerussian.com \
--cc=romosan@sycorax.lbl.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).