* [PATCH 1/3] sstfb: fix pixclock setting on Voodoo 1/2 cards
@ 2007-03-11 10:22 Antonino A. Daplas
2007-03-11 12:36 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Antonino A. Daplas @ 2007-03-11 10:22 UTC (permalink / raw)
To: Andrew Morton; +Cc: Ondrej Zajicek, Linux Fbdev development list
From: Ondrej Zajicek <santiago@crfreenet.org>
Pixclock setting in sstfb didn't work with my Voodoo 2 card
with ICS 5342 DAC (this DAC requires two consecutive writes
to one of its registers to program pixclock - maybe first
write merged with second).
This patch fixes bug with pixclock setting. It is against
2.6.21-rc1 .
Signed-off-by: Ondrej Zajicek <santiago@crfreenet.org>
Signed-off-by: Antonino Daplas <adaplas@gmail.com>
---
drivers/video/sstfb.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/video/sstfb.c b/drivers/video/sstfb.c
index 59cd1e7..62fa550 100644
--- a/drivers/video/sstfb.c
+++ b/drivers/video/sstfb.c
@@ -257,6 +257,7 @@ static void __sst_dac_write(u8 __iomem *
r_dprintk("sst_dac_write(%#x, %#x)\n", reg, val);
reg &= 0x07;
__sst_write(vbase, DAC_DATA,(((u32)reg << 8)) | (u32)val);
+ __sst_wait_idle(vbase);
}
/* indexed access to ti/att dacs */
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-03-11 13:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-11 10:22 [PATCH 1/3] sstfb: fix pixclock setting on Voodoo 1/2 cards Antonino A. Daplas
2007-03-11 12:36 ` Andrew Morton
2007-03-11 13:03 ` Antonino A. Daplas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).