Re: [PATCH] packed pixel image blit optimizations.

["Antonino A. Daplas" <adaplas@gmail.com>]

On Thu, 2007-05-03 at 20:55 +0100, James Simmons wrote:
> > > > I don't have to test the patch to see that it is not endian-correct and
> > > > that it will be many times slower than the old code.
> > > 
> > > I have tested on big endian framebuffers and it does work.
> > 
> > How about little-endian?
> 
> Worked as well.
>  

Not for me, vesafb 8x16 font at 1024x768-8.

> > >  I was attempting
> > > to shrink the code for embedded devices. We can have the fastest code possible
> > > but its no good if a cell phone can't run it :-(
> > 
> > Nonsense, the difference is a few kb at most. And I'm not talking about
> > a few percent speed difference, I'm talking 2, 3 maybe 5x slower.
> > 
> > Please do basic tests first.
> 
> Show me the numbers!!!

I think that's your job, but here goes:

time cat linux/MAINTAINERS

old
real    0m5.406s
user    0m0.001s
sys     0m5.401s

your patch
real    0m36.859s
user    0m0.002s
sys     0m36.843s

Tony


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/