From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Antonino A. Daplas" Subject: Re: [PATCH] packed pixel image blit optimizations. Date: Fri, 04 May 2007 04:06:59 +0800 Message-ID: <1178222819.28617.33.camel@daplas> References: <1178141603.4606.44.camel@daplas> <1178220277.28617.7.camel@daplas> <1178221493.28617.21.camel@daplas> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1HjhZz-0005HY-QZ for linux-fbdev-devel@lists.sourceforge.net; Thu, 03 May 2007 13:07:07 -0700 Received: from py-out-1112.google.com ([64.233.166.183]) by mail.sourceforge.net with esmtp (Exim 4.44) id 1HjhZy-0001jo-Ck for linux-fbdev-devel@lists.sourceforge.net; Thu, 03 May 2007 13:07:07 -0700 Received: by py-out-1112.google.com with SMTP id a29so513726pyi for ; Thu, 03 May 2007 13:07:05 -0700 (PDT) In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-fbdev-devel-bounces@lists.sourceforge.net Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net To: James Simmons Cc: linux-fbdev-devel@lists.sourceforge.net On Thu, 2007-05-03 at 20:55 +0100, James Simmons wrote: > > > > I don't have to test the patch to see that it is not endian-correct and > > > > that it will be many times slower than the old code. > > > > > > I have tested on big endian framebuffers and it does work. > > > > How about little-endian? > > Worked as well. > Not for me, vesafb 8x16 font at 1024x768-8. > > > I was attempting > > > to shrink the code for embedded devices. We can have the fastest code possible > > > but its no good if a cell phone can't run it :-( > > > > Nonsense, the difference is a few kb at most. And I'm not talking about > > a few percent speed difference, I'm talking 2, 3 maybe 5x slower. > > > > Please do basic tests first. > > Show me the numbers!!! I think that's your job, but here goes: time cat linux/MAINTAINERS old real 0m5.406s user 0m0.001s sys 0m5.401s your patch real 0m36.859s user 0m0.002s sys 0m36.843s Tony ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/