From: "Antonino A. Daplas" <adaplas@gmail.com>
To: Krzysztof Helt <krzysztof.h1@wp.pl>
Cc: linux-fbdev-devel <linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: [PATCH] smart blitter usage for scrolling
Date: Thu, 10 May 2007 13:49:57 +0800 [thread overview]
Message-ID: <1178776197.4861.39.camel@daplas> (raw)
In-Reply-To: <4642b06be589b@wp.pl>
On Thu, 2007-05-10 at 07:40 +0200, Krzysztof Helt wrote:
> Dnia 9-05-2007 o godz. 16:19 Antonino A. Daplas napisał(a):
> > This sounds quite logical to me. However, I would rather that
> you
> > create a new scrolling mode (ie SCROLL_MOVE_REDRAW and
> > SCROLL_WRAP_REDRAW). Then create a new FBINFO_HWACCEL flag that
> will
> > enable SCROLL_PAN/WRAP_MOVE_REDRAW and perhaps another one that
> will
> > enable MERGE_BLIT.
> >
>
> I understand that you want creating a new flag instead of ifdefs
> but this new method should not be much slower in the worst case
> and much faster on average. I would rather consider replacing the
> existing SCROLL_MOVE mode (so no ifdefs after some
> experimental/test period).
> Also, the capabilities of hardware for the new method are exactly
> the same as for the old SCROLL_MOVE. Every time the
> HWACCEL_COPYAREA is selected the new scroll method should also be
> selected. The new HWACCEL flag seems to be alwyas a copy of
> HWACCEL_COPYAREA flag.
>
If you think that this can be a drop-in replacement for the old one,
then let's do just that (replace the old code) and have it tested in the
-mm tree.
> The MERGE_BLITS is a different story but my suspection is that
> does not give any real benefit (in the few % range plus or minus)
> and could be dropped completely. I left it to allow members of
> this list testing and return a feedback. If my supection is true
> the whole MERGE_BLITS can be dropped to simplify the code.
>
Yeah, even without the #ifdefs, the code is quite ugly.
Okay, let's go for the simplest, cleanest and clearest code then.
Tony
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel
next prev parent reply other threads:[~2007-05-10 5:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-09 7:05 [PATCH] smart blitter usage for scrolling Krzysztof Helt
2007-05-09 14:19 ` Antonino A. Daplas
2007-05-10 5:40 ` Krzysztof Helt
2007-05-10 5:49 ` Antonino A. Daplas [this message]
2007-05-10 5:56 ` Antonino A. Daplas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178776197.4861.39.camel@daplas \
--to=adaplas@gmail.com \
--cc=krzysztof.h1@wp.pl \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).