logos work/apply when?

logos work/apply when?

[Randy Dunlap]

Hi,

Is there some kernel config or video config (possibly set at boot time
via vga=xyz or video=wxy) where one or more of the logos is not
applicable?  or the other way:  are there certain kernel or video
configs where only certain logos are applicable?


I've tested vesafb with LOGO_LINUX_VGA16 but I can't see the logo.
I do see an empty space for it at the top of the screen area, however.
(booting with vga=0x317 in /etc/lilo.conf file)

When I use LOGO_LINUX_CLUT224 instead, I do see the logo.

or when I use FB_VGA16 instead of vesafb and also use LOGO_LINUX_VGA16,
I can see the logo.

I'm just trying to understand when/why I should expect (or not expect)
to see a logo (if it is enabled).

Thanks.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

Re: logos work/apply when?

[Antonino A. Daplas]

[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]

On Thu, 2007-07-12 at 13:08 -0700, Randy Dunlap wrote: 
> Hi,
> 
> Is there some kernel config or video config (possibly set at boot time
> via vga=xyz or video=wxy) where one or more of the logos is not
> applicable?  or the other way:  are there certain kernel or video
> configs where only certain logos are applicable?
> 
> 
> I've tested vesafb with LOGO_LINUX_VGA16 but I can't see the logo.
> I do see an empty space for it at the top of the screen area, however.
> (booting with vga=0x317 in /etc/lilo.conf file)
> 
> When I use LOGO_LINUX_CLUT224 instead, I do see the logo.
> 
> or when I use FB_VGA16 instead of vesafb and also use LOGO_LINUX_VGA16,
> I can see the logo.
> 
> I'm just trying to understand when/why I should expect (or not expect)
> to see a logo (if it is enabled).

It's a bug. And I've been wanting to fix that for some time. Logo's with
depths <= the fb depth should still be shown. The problem is that VGA16
and monochrome logos do not contain color information, so we have to use
the console palette (and not create a new one). Try the attached patch.

Tony  


[-- Attachment #2: fb_logo.diff --]
[-- Type: text/x-patch, Size: 1589 bytes --]

diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c
index 7f3a0cc..b6a0a1c 100644
--- a/drivers/video/fbmem.c
+++ b/drivers/video/fbmem.c
@@ -244,8 +244,17 @@ static void fb_set_logo(struct fb_info *
 	u8 xor = (info->fix.visual == FB_VISUAL_MONO01) ? 0xff : 0;
 	u8 fg = 1, d;
 
-	if (fb_get_color_depth(&info->var, &info->fix) == 3)
-		fg = 7;
+	switch (fb_get_color_depth(&info->var, &info->fix)) {
+	case 1:
+		fg = 1;
+		break;
+	case 2:
+		fg = 3;
+		break;
+	default:
+		fg = 7; 
+		break;
+	}
 
 	if (info->fix.visual == FB_VISUAL_MONO01 ||
 	    info->fix.visual == FB_VISUAL_MONO10)
@@ -428,21 +437,6 @@ int fb_prepare_logo(struct fb_info *info
 		depth = 4;
 	}
 
-	if (depth >= 8) {
-		switch (info->fix.visual) {
-		case FB_VISUAL_TRUECOLOR:
-			fb_logo.needs_truepalette = 1;
-			break;
-		case FB_VISUAL_DIRECTCOLOR:
-			fb_logo.needs_directpalette = 1;
-			fb_logo.needs_cmapreset = 1;
-			break;
-		case FB_VISUAL_PSEUDOCOLOR:
-			fb_logo.needs_cmapreset = 1;
-			break;
-		}
-	}
-
 	/* Return if no suitable logo was found */
 	fb_logo.logo = fb_find_logo(depth);
 
@@ -467,6 +461,22 @@ int fb_prepare_logo(struct fb_info *info
 		fb_logo.depth = 4;
 	else
 		fb_logo.depth = 1;		
+
+	if (fb_logo.depth > 4 && depth >= 8) {
+		switch (info->fix.visual) {
+		case FB_VISUAL_TRUECOLOR:
+			fb_logo.needs_truepalette = 1;
+			break;
+		case FB_VISUAL_DIRECTCOLOR:
+			fb_logo.needs_directpalette = 1;
+			fb_logo.needs_cmapreset = 1;
+			break;
+		case FB_VISUAL_PSEUDOCOLOR:
+			fb_logo.needs_cmapreset = 1;
+			break;
+		}
+	}
+
 	return fb_logo.logo->height;
 }
 

[-- Attachment #3: Type: text/plain, Size: 286 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

[-- Attachment #4: Type: text/plain, Size: 182 bytes --]

_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel

Re: logos work/apply when?

[Randy Dunlap]

On Fri, 13 Jul 2007 07:50:51 +0800 Antonino A. Daplas wrote:

> On Thu, 2007-07-12 at 13:08 -0700, Randy Dunlap wrote: 
> > Hi,
> > 
> > Is there some kernel config or video config (possibly set at boot time
> > via vga=xyz or video=wxy) where one or more of the logos is not
> > applicable?  or the other way:  are there certain kernel or video
> > configs where only certain logos are applicable?
> > 
> > 
> > I've tested vesafb with LOGO_LINUX_VGA16 but I can't see the logo.
> > I do see an empty space for it at the top of the screen area, however.
> > (booting with vga=0x317 in /etc/lilo.conf file)
> > 
> > When I use LOGO_LINUX_CLUT224 instead, I do see the logo.
> > 
> > or when I use FB_VGA16 instead of vesafb and also use LOGO_LINUX_VGA16,
> > I can see the logo.
> > 
> > I'm just trying to understand when/why I should expect (or not expect)
> > to see a logo (if it is enabled).
> 
> It's a bug. And I've been wanting to fix that for some time. Logo's with
> depths <= the fb depth should still be shown. The problem is that VGA16
> and monochrome logos do not contain color information, so we have to use
> the console palette (and not create a new one). Try the attached patch.

That works in my testing.  Thanks.

So when all 3 of these are enabled:
CONFIG_LOGO_LINUX_MONO=y
CONFIG_LOGO_LINUX_VGA16=y
CONFIG_LOGO_LINUX_CLUT224=y
is the one with most depth that is supported by the fb driver used?

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

Re: logos work/apply when?

[Antonino A. Daplas]

On Fri, 2007-07-13 at 11:06 -0700, Randy Dunlap wrote:
> On Fri, 13 Jul 2007 07:50:51 +0800 Antonino A. Daplas wrote:
> 
> > On Thu, 2007-07-12 at 13:08 -0700, Randy Dunlap wrote: 

> So when all 3 of these are enabled:
> CONFIG_LOGO_LINUX_MONO=y
> CONFIG_LOGO_LINUX_VGA16=y
> CONFIG_LOGO_LINUX_CLUT224=y
> is the one with most depth that is supported by the fb driver used?

Yes.

Tony


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/