From: "Antonino A. Daplas" <adaplas@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linux Fbdev development list <linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: [PATCH 18/33] pm3fb: mtrr support and noaccel option
Date: Fri, 27 Jul 2007 05:51:12 +0800 [thread overview]
Message-ID: <1185486672.4565.5.camel@daplas> (raw)
In-Reply-To: <20070726131238.9ed4bc7a.akpm@linux-foundation.org>
On Thu, 2007-07-26 at 13:12 -0700, Andrew Morton wrote:
> On Thu, 26 Jul 2007 20:23:55 +0800 "Antonino A. Daplas" <adaplas@gmail.com> wrote:
>
> > From: Krzysztof Helt <krzysztof.h1@wp.pl>
> >
> > This patch adds usage of MTRR registers and two new options: noaccel and
> > nomtrr.
> >
>
> It's been tested with CONFIG_MTRR=n, I trust?
>
> > +#ifdef CONFIG_MTRR
> > +#include <asm/mtrr.h>
> > +#endif
>
> Is the ifdef there needed for a successful compile? If not, it's nicer to
> leave it out.
Yes, not all archs have asm/mtrr.h.
Tony
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-07-26 21:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 12:23 [PATCH 18/33] pm3fb: mtrr support and noaccel option Antonino A. Daplas
2007-07-26 20:12 ` Andrew Morton
2007-07-26 21:51 ` Antonino A. Daplas [this message]
2007-07-27 17:19 ` Krzysztof Helt
2007-07-27 19:33 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185486672.4565.5.camel@daplas \
--to=adaplas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).