Re: [PATCH] tdfxfb: hardware cursor

["Antonino A. Daplas" <adaplas@gmail.com>]

On Sat, 2007-07-28 at 10:26 +0200, Krzysztof Helt wrote:
> From: Krzysztof Helt <krzysztof.h1@wp.pl>
> 
> This patch adds hardware cursor support to the tdfxfb driver.
> 
> Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
> 
> ---
> 
> This patch requires all tdfxfb patches from the -mm tree and the source code 
> improvement patch sent yesterday to this list.
> 
> I am not sure if the FB_CUR_SETIMAGE and FB_CUR_SETSHAPE are implemented
> correctly (the mask is always mask and the image is xor or and of the mask and data).
> The cursor works correctly on Voodoo3 2000 PCI with this patch.
> 
> I added a separate option to Kconfig to enable this feature but I am eager to remove
> the option and make the hardware cursor always used after someone can confirm
> it is ok on Banshee and Voodoo4/5 (no ifdefs).

I would rather that you make the hardware cursor support permanent
(instead of adding another Kconfig option) and just have a boot option
to enable/disable the hardware cursor.

Tony



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/