From: "Antonino A. Daplas" <adaplas@gmail.com>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Chandramouli Narayanan <mouli@linux.intel.com>,
ak@suse.de, linux-kernel@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-fbdev-devel@lists.sourceforge.net,
akpm@linux-foundation.org, Yinghai Lu <yhlu.kernel@gmail.com>
Subject: Re: [PATCH 4/5] x86_64 EFI support -v3: EFI framebuffer driver
Date: Wed, 01 Aug 2007 13:55:12 +0800 [thread overview]
Message-ID: <1185947712.4688.22.camel@daplas> (raw)
In-Reply-To: <1185851582.23149.29.camel@caritas-dev.intel.com>
On Tue, 2007-07-31 at 11:13 +0800, Huang, Ying wrote:
> +
> +#include <linux/delay.h>
> +#include <linux/errno.h>
> +#include <linux/fb.h>
> +#include <linux/kernel.h>
> +#include <linux/init.h>
> +#include <linux/ioport.h>
> +#include <linux/mm.h>
> +#include <linux/module.h>
> +#include <linux/platform_device.h>
> +#include <linux/screen_info.h>
> +#include <linux/slab.h>
> +#include <linux/string.h>
> +#include <linux/dmi.h>
> +#include <linux/efi.h>
> +#include <linux/io.h>
> +
> +#include <video/vga.h>
> +
I don't see any problems with this driver, just a few minor nits.
Do you really need all the #include's?
I presume this driver only supports bpp 16 and above?
Tony
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-08-01 5:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 3:13 [PATCH 4/5] x86_64 EFI support -v3: EFI framebuffer driver Huang, Ying
2007-07-31 4:34 ` Eric W. Biederman
2007-07-31 6:35 ` Huang, Ying
2007-08-01 5:55 ` Antonino A. Daplas [this message]
2007-08-03 6:56 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185947712.4688.22.camel@daplas \
--to=adaplas@gmail.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mouli@linux.intel.com \
--cc=randy.dunlap@oracle.com \
--cc=yhlu.kernel@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).