From: Jan Altenberg <jan.altenberg@linutronix.de>
To: Andrew Victor <andrew@sanpeople.com>,
linux-fbdev-devel@lists.sourceforge.net
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
Haavard Skinnemoen <hskinnemoen@atmel.com>,
Jan Altenberg <jan.altenberg@linutronix.de>,
Patrice Vilchez <patrice.vilchez@rfo.atmel.com>,
Nicolas Ferre <nicolas.ferre@rfo.atmel.com>
Subject: [PATCH] AT91: include atmel_lcdc.h in at91sam926{1,3}_devices.c
Date: Wed, 01 Aug 2007 15:22:52 +0200 [thread overview]
Message-ID: <1185974572.3854.52.camel@bender.lan> (raw)
Hi all,
current git doesn't compile for CONFIG_ARCH_AT91SAM926{1,3} and
and CONFIG_FB_ATMEL enabled, due to a missing inclusion of atmel_lcdc.h:
/home/jan/kernel/git/linux-2.6/arch/arm/mach-at91/at91sam9263_devices.c: In function ‘at91_add_device_lcdc’:
/home/jan/kernel/git/linux-2.6/arch/arm/mach-at91/at91sam9263_devices.c:688: error: dereferencing pointer to incomplete type
/home/jan/kernel/git/linux-2.6/arch/arm/mach-at91/at91sam9263_devices.c:688: error: ‘lcdc_data’ has an incomplete type
This error should also have occured in the past, because atmel_lcdc.h
has never been included.
Signed-off-by: Jan Altenberg <jan.altenberg@linutronix.de>
---
arch/arm/mach-at91/at91sam9261_devices.c | 2 ++
arch/arm/mach-at91/at91sam9263_devices.c | 2 ++
2 files changed, 4 insertions(+)
Index: linux-2.6/arch/arm/mach-at91/at91sam9261_devices.c
===================================================================
--- linux-2.6.orig/arch/arm/mach-at91/at91sam9261_devices.c
+++ linux-2.6/arch/arm/mach-at91/at91sam9261_devices.c
@@ -15,6 +15,8 @@
#include <linux/platform_device.h>
+#include <video/atmel_lcdc.h>
+
#include <asm/arch/board.h>
#include <asm/arch/gpio.h>
#include <asm/arch/at91sam9261.h>
Index: linux-2.6/arch/arm/mach-at91/at91sam9263_devices.c
===================================================================
--- linux-2.6.orig/arch/arm/mach-at91/at91sam9263_devices.c
+++ linux-2.6/arch/arm/mach-at91/at91sam9263_devices.c
@@ -14,6 +14,8 @@
#include <linux/platform_device.h>
+#include <video/atmel_lcdc.h>
+
#include <asm/arch/board.h>
#include <asm/arch/gpio.h>
#include <asm/arch/at91sam9263.h>
reply other threads:[~2007-08-01 13:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185974572.3854.52.camel@bender.lan \
--to=jan.altenberg@linutronix.de \
--cc=andrew@sanpeople.com \
--cc=hskinnemoen@atmel.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@rfo.atmel.com \
--cc=patrice.vilchez@rfo.atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).