From: "Antonino A. Daplas" <adaplas@gmail.com>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: "Geert.Uytterhoeven" <Geert.Uytterhoeven@sonycom.com>
Subject: Re: [PATCH/RFC] fbdev: fb_create_modedb() non-static `int first = 1; '
Date: Thu, 09 Aug 2007 05:26:59 +0800 [thread overview]
Message-ID: <1186608419.4825.0.camel@daplas> (raw)
In-Reply-To: <Pine.LNX.4.62.0708081410170.15170@pademelon.sonytel.be>
On Wed, 2007-08-08 at 14:11 +0200, Geert Uytterhoeven wrote:
> >From looking at the code flow, `int first' in fb_create_modedb() should be
> static.
>
> Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
> ---
> Or should it be initialized to 1 outside the loop?
It should be outside the loop. Thanks.
Tony
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
prev parent reply other threads:[~2007-08-08 21:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 12:11 [PATCH/RFC] fbdev: fb_create_modedb() non-static `int first = 1; ' Geert Uytterhoeven
2007-08-08 21:26 ` Antonino A. Daplas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1186608419.4825.0.camel@daplas \
--to=adaplas@gmail.com \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).