Re: [PATCH 2/2] [VIDEO FRAMEBUFFER] Blackfin BF54x framebuffer device driver for a SHARP LQ043T1DG01 TFT LCD

Re: [PATCH 2/2] [VIDEO FRAMEBUFFER] Blackfin BF54x framebuffer device driver for a SHARP LQ043T1DG01 TFT LCD

[Antonino A. Daplas]

On Wed, 2007-09-26 at 11:43 +0800, Bryan Wu wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
> Date: Wed, 26 Sep 2007 11:33:01 +0800
> Subject: [PATCH 2/2] [VIDEO FRAMEBUFFER] Blackfin BF54x framebuffer device driver for a SHARP LQ043T1DG01 TFT LCD
> 
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> Signed-off-by: Bryan Wu <bryan.wu@analog.com>
> ---
>  drivers/video/Kconfig                         |    9 +
>  drivers/video/Makefile                        |    1 +
>  drivers/video/bf54x-lq043.c                   |  786 +++++++++++++++++++++++++
>  include/asm-blackfin/mach-bf548/bf54x-lq043.h |   30 +
>  4 files changed, 826 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/video/bf54x-lq043.c
>  create mode 100644 include/asm-blackfin/mach-bf548/bf54x-lq043.h
> 
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 5216c11..41fae00 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -535,6 +535,15 @@ config FB_VGA16
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called vga16fb.
>  
> +config FB_BF54X_LQ043
> +	tristate "SHARP LQ043 TFT LCD (BF548 EZKIT)"
> +	depends on FB && (BF54x)
> +	select FB_CFB_FILLRECT
> +	select FB_CFB_COPYAREA
> +	select FB_CFB_IMAGEBLIT
> +	help
> +	 This is the framebuffer device driver for a SHARP LQ043T1DG01 TFT LCD
> +
>  config FB_STI
>  	tristate "HP STI frame buffer device support"
>  	depends on FB && PARISC
> diff --git a/drivers/video/Makefile b/drivers/video/Makefile
> index 06eec7b..359e560 100644
> --- a/drivers/video/Makefile
> +++ b/drivers/video/Makefile
> @@ -122,6 +122,7 @@ obj-$(CONFIG_FB_OF)               += offb.o
>  
>  # the test framebuffer is last
>  obj-$(CONFIG_FB_VIRTUAL)          += vfb.o
> +obj-$(CONFIG_FB_BF54X_LQ043)	  += bf54x-lq043.o

It's standard that we suffix all framebuffer drivers with an 'fb'. I'm
making it so in my tree.

Also, you shouldn't place your driver after vfb, that's why there's a
comment that the test framebuffer is last. If someone accidentally
enables vfb, he/she will get a blank screen. So I'm moving it under the
platform driver section. 

Tony




-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/