From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH 06/17] platinumfb: Fix resource management Date: Sun, 30 Sep 2007 07:53:05 +1000 Message-ID: <1191102785.28637.2.camel@pasglop> References: <46FDAA91.4080205@gmail.com> Reply-To: benh@kernel.crashing.org, linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1IbkFN-0000O6-PY for linux-fbdev-devel@lists.sourceforge.net; Sat, 29 Sep 2007 14:53:14 -0700 Received: from gate.crashing.org ([63.228.1.57] ident=[U2FsdGVkX18Uo9pnCUJ6cBtd7/s6fq6eAAsve/9tADw=]) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1IbkFM-0006Xb-CT for linux-fbdev-devel@lists.sourceforge.net; Sat, 29 Sep 2007 14:53:13 -0700 In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-fbdev-devel-bounces@lists.sourceforge.net Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net To: Geert Uytterhoeven Cc: Andrew Morton , Linux Fbdev development list , Andy Whitcroft > Probably scripts/checkpatch.pl should be taught to complain about > `#undef DEBUG'. Why ? Whenever I have things that are #ifdef DEBUG in the file (such as dev_dbg statements), I always leave a #undef DEBUG statement at the top. That way, I know I can enable debug in that file by flicking it. Ben. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/