From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: Antonino Daplas <adaplas@gmail.com>
Subject: Re: [PATCH] fb_ddc: Fix DDC lines quirk
Date: Sat, 24 Nov 2007 08:00:04 +1100 [thread overview]
Message-ID: <1195851604.7195.10.camel@pasglop> (raw)
In-Reply-To: <20071123205309.7c40a931@hyperion.delvare>
On Fri, 2007-11-23 at 20:53 +0100, Jean Delvare wrote:
> On Thu, 22 Nov 2007 06:58:49 +1100, Benjamin Herrenschmidt wrote:
> >
> > On Sun, 2007-11-18 at 14:21 +0100, Jean Delvare wrote:
> > > The code in fb_ddc_read() is said to be based on the implementation
> > > of the radeon driver:
> > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=fc5891c8a3ba284f13994d7bc1f1bfa8283982de
> > >
> > > However, comparing the old radeon driver code with the new fb_ddc code
> > > reveals some differences. Most notably, the I2C bus lines are held at
> > > the end of the function, while the original code was releasing them
> > > (as the comment above correctly says.)
> >
> > .../...
> >
> > > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> >
> > Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> Thanks. Antonino, this patch fixes two reported regressions. Can you
> please send it to Linus before 2.6.24 is released? Thanks.
It should also be send to -stable I believe and possibly distros.
Cheers,
Ben.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
prev parent reply other threads:[~2007-11-23 21:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-18 13:21 [PATCH] fb_ddc: Fix DDC lines quirk Jean Delvare
2007-11-18 20:40 ` Benjamin Herrenschmidt
2007-11-21 19:58 ` Benjamin Herrenschmidt
2007-11-23 19:53 ` Jean Delvare
2007-11-23 21:00 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1195851604.7195.10.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=adaplas@gmail.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).