From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/3] radeonfb: Speed up the I2C buses
Date: Wed, 13 Feb 2008 07:56:57 +1100 [thread overview]
Message-ID: <1202849817.7410.11.camel@pasglop> (raw)
In-Reply-To: <20080212101915.1dce8475@hyperion.delvare>
On Tue, 2008-02-12 at 10:19 +0100, Jean Delvare wrote:
> There is no reason to drive the radeon I2C buses at such a low
> speed, so bump it from 12.5 kbps to 50 kbps. The Intel (i810) and
> Matrox framebuffer drivers already run their I2C bus at this speed.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
Ack.
> ---
> This patch was already sent on:
> * 2007-03-08
> * 2007-09-09
>
> drivers/video/aty/radeon_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.21-git.orig/drivers/video/aty/radeon_i2c.c 2007-05-09 10:52:26.000000000 +0200
> +++ linux-2.6.21-git/drivers/video/aty/radeon_i2c.c 2007-05-09 10:55:51.000000000 +0200
> @@ -77,7 +77,7 @@ static int radeon_setup_i2c_bus(struct r
> chan->algo.setscl = radeon_gpio_setscl;
> chan->algo.getsda = radeon_gpio_getsda;
> chan->algo.getscl = radeon_gpio_getscl;
> - chan->algo.udelay = 40;
> + chan->algo.udelay = 10;
> chan->algo.timeout = 20;
> chan->algo.data = chan;
>
>
>
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
prev parent reply other threads:[~2008-02-12 20:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 9:19 [PATCH 1/3] radeonfb: Speed up the I2C buses Jean Delvare
2008-02-12 20:56 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202849817.7410.11.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).