From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH 1/3] radeonfb: Speed up the I2C buses Date: Wed, 13 Feb 2008 07:56:57 +1100 Message-ID: <1202849817.7410.11.camel@pasglop> References: <20080212101915.1dce8475@hyperion.delvare> Reply-To: benh@kernel.crashing.org, linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1JP2Bm-0008JE-R0 for linux-fbdev-devel@lists.sourceforge.net; Tue, 12 Feb 2008 12:57:14 -0800 Received: from gate.crashing.org ([63.228.1.57] ident=[U2FsdGVkX1/VvYz0z1FDzB2Y0u6Ruu2yYcN4FfsF7FI=]) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1JP2Bl-0001Ui-81 for linux-fbdev-devel@lists.sourceforge.net; Tue, 12 Feb 2008 12:57:14 -0800 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id m1CKv9IU011242 for ; Tue, 12 Feb 2008 14:57:10 -0600 In-Reply-To: <20080212101915.1dce8475@hyperion.delvare> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-fbdev-devel-bounces@lists.sourceforge.net Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net To: linux-fbdev-devel@lists.sourceforge.net On Tue, 2008-02-12 at 10:19 +0100, Jean Delvare wrote: > There is no reason to drive the radeon I2C buses at such a low > speed, so bump it from 12.5 kbps to 50 kbps. The Intel (i810) and > Matrox framebuffer drivers already run their I2C bus at this speed. > > Signed-off-by: Jean Delvare Ack. > --- > This patch was already sent on: > * 2007-03-08 > * 2007-09-09 > > drivers/video/aty/radeon_i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-2.6.21-git.orig/drivers/video/aty/radeon_i2c.c 2007-05-09 10:52:26.000000000 +0200 > +++ linux-2.6.21-git/drivers/video/aty/radeon_i2c.c 2007-05-09 10:55:51.000000000 +0200 > @@ -77,7 +77,7 @@ static int radeon_setup_i2c_bus(struct r > chan->algo.setscl = radeon_gpio_setscl; > chan->algo.getsda = radeon_gpio_getsda; > chan->algo.getscl = radeon_gpio_getscl; > - chan->algo.udelay = 40; > + chan->algo.udelay = 10; > chan->algo.timeout = 20; > chan->algo.data = chan; > > > ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/