[PATCH] pm2fb: change option mode to mode_option

[PATCH] pm2fb: change option mode to mode_option

[Krzysztof Helt]

From: Krzysztof Helt <krzysztof.h1@wp.pl>

This patch changes the option "mode_option" into "mode".

Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
---

This is one step toward changing all fb drivers to have common "mode_option" parameter.

This patch was created against 2.6.25-rc1 kernel.

diff -urp linux-ref/drivers/video/pm2fb.c linux-2.6.25/drivers/video/pm2fb.c
--- linux-ref/drivers/video/pm2fb.c	2008-02-13 22:42:55.493782146 +0100
+++ linux-2.6.25/drivers/video/pm2fb.c	2008-02-14 21:43:53.238762148 +0100
@@ -67,7 +67,7 @@
  * Driver data
  */
 static int hwcursor = 1;
-static char *mode __devinitdata;
+static char *mode_option __devinitdata;
 
 /*
  * The XFree GLINT driver will (I think to implement hardware cursor
@@ -1680,10 +1680,10 @@ static int __devinit pm2fb_probe(struct 
 		info->pixmap.scan_align = 1;
 	}
 
-	if (!mode)
-		mode = "640x480@60";
+	if (!mode_option)
+		mode_option = "640x480@60";
 
-	err = fb_find_mode(&info->var, info, mode, NULL, 0, NULL, 8);
+	err = fb_find_mode(&info->var, info, mode_option, NULL, 0, NULL, 8);
 	if (!err || err == 4)
 		info->var = pm2fb_var;
 
@@ -1797,7 +1797,7 @@ static int __init pm2fb_setup(char *opti
 		else if (!strncmp(this_opt, "noaccel", 7))
 			noaccel = 1;
 		else
-			mode = this_opt;
+			mode_option = this_opt;
 	}
 	return 0;
 }
@@ -1833,8 +1833,8 @@ static void __exit pm2fb_exit(void)
 #ifdef MODULE
 module_exit(pm2fb_exit);
 
-module_param(mode, charp, 0);
-MODULE_PARM_DESC(mode, "Preferred video mode e.g. '648x480-8@60'");
+module_param(mode_option, charp, 0);
+MODULE_PARM_DESC(mode_option, "Initial video mode e.g. '648x480-8@60'");
 module_param(lowhsync, bool, 0);
 MODULE_PARM_DESC(lowhsync, "Force horizontal sync low regardless of mode");
 module_param(lowvsync, bool, 0);


---------------------------------------------------------------------- 	
Sprawdz gdzie lezy snieg, czy dzialaja armatki
i jak przygotowane sa stoki >>> http://link.interia.pl/f1cfc



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Re: [PATCH] pm2fb: change option mode to mode_option

[Andrew Morton]

On Thu, 14 Feb 2008 22:52:13 +0100
Krzysztof Helt <krzysztof.h1@poczta.fm> wrote:

> From: Krzysztof Helt <krzysztof.h1@wp.pl>
> 
> This patch changes the option "mode_option" into "mode".
> 
> ...
>  
> -module_param(mode, charp, 0);
> -MODULE_PARM_DESC(mode, "Preferred video mode e.g. '648x480-8@60'");
> +module_param(mode_option, charp, 0);
> +MODULE_PARM_DESC(mode_option, "Initial video mode e.g. '648x480-8@60'");
>  module_param(lowhsync, bool, 0);
>  MODULE_PARM_DESC(lowhsync, "Force horizontal sync low regardless of mode");
>  module_param(lowvsync, bool, 0);

But it's not backward compatible.  We'll break people's setups.

Not _much_, and we can probably live with it.  But surely it'd be pretty
simple to retain the old option as well?


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Re: [PATCH] pm2fb: change option mode to mode_option

[krzysztof.h1]

Andrew Morton napisa³(a):
> On Thu, 14 Feb 2008 22:52:13 +0100
> Krzysztof Helt >krzysztof.h1@poczta.fm> wrote:
> 
> > From: Krzysztof Helt >krzysztof.h1@wp.pl>
> > 
> > This patch changes the option "mode_option" into "mode".
> > 
> > ...
> >  
> > -module_param(mode, charp, 0);
> > -MODULE_PARM_DESC(mode, "Preferred video mode e.g. '648x480-8@60'");
> > +module_param(mode_option, charp, 0);
> > +MODULE_PARM_DESC(mode_option, "Initial video mode e.g.
> '648x480-8@60'");
> >  module_param(lowhsync, bool, 0);
> >  MODULE_PARM_DESC(lowhsync, "Force horizontal sync low regardless of
> mode");
> >  module_param(lowvsync, bool, 0);
> 
> But it's not backward compatible.  We'll break people's setups.
> 
> Not _much_, and we can probably live with it.  But surely it'd be pretty
> simple to retain the old option as well?
> 
> 
I'll fix this issue in all patches.

The changed drivers are relatively new. They were added or reworked not longer than 1 year ago (around 2.6.22).

Regards,
Krzysztof



----------------------------------------------------------------------
Masz ostatnia szanse !
Sprawdz >>> http://link.interia.pl/f1d02  


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Re: [PATCH] pm2fb: change option mode to mode_option

[Alain Kalker]

On Fri, 2008-02-15 at 15:15 +0100, krzysztof.h1@poczta.fm wrote:
> Andrew Morton napisał(a):
> > On Thu, 14 Feb 2008 22:52:13 +0100
> > Krzysztof Helt >krzysztof.h1@poczta.fm> wrote:
> > 
> > > From: Krzysztof Helt >krzysztof.h1@wp.pl>
> > > 
> > > This patch changes the option "mode_option" into "mode".

Thanks very much for your work Krzysztof. I hope that in time most of
the drivers can be made to use the ModeDB framework, so handling of
modes can be done in one place. If I can be of any help, please let me
know. 

Regards,
Alain

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel